chrome/app/generated_resources.grd - Issue 2337963003: Plumb through notification action types and placeholders on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 2337963003: Plumb through notification action types and placeholders on Android (Closed)

Patch Set: Final review nits Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilderTest.java ('k') | chrome/browser/notifications/notification_platform_bridge_android.cc » ('j') | ui/message_center/notification.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index 1a604c71edbf64058a7328079cac1091306d01a9..28c1112ba851903518b7fdaadd3d6fa557762a69 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -12144,6 +12144,9 @@ Tell us what happened exactly before you got the profile error message:

Enable custom layouts for Web Notifications. They will have subtle layout improvements that are otherwise not possible.

</message>

+ <message name="IDS_NOTIFICATION_REPLY_PLACEHOLDER" desc="Placeholder text shown in the text box before any text is entered when replying directly to a notification.">

+ Send message

awdf 2016/09/27 14:45:27 Do I need to add someone from https://cs.chromium.

Peter Beverloo 2016/09/27 15:28:32 No, because of the following line in the OWNERS fi

+ </message>

</if>