Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2337923002:
[regexp] Merge exec implementations (Closed)
|
Created:
4 years, 3 months ago by jgruber Modified:
4 years, 3 months ago Reviewers:
Dan Ehrenberg CC:
v8-reviews_googlegroups.com, Yang Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[regexp] Merge exec implementations
RegExpSubclassExecJS and RegExpExecJS only differed in the additional
TO_BOOLEAN on global and sticky flags and the useless (i < 0) check.
R=littledan@chromium.org
BUG=v8:5339
Committed: https://crrev.com/ee50e89b406cf5a247afccaf4d4c548f4b8f0523
Cr-Commit-Position: refs/heads/master@{#39417}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Rename RegExpSubclassExecJS->RegExpExecJS #Messages
Total messages: 27 (17 generated)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Does this patch change the performance of RegExps? https://codereview.chromium.org/2337923002/diff/1/src/js/regexp.js File src/js/regexp.js (right): https://codereview.chromium.org/2337923002/diff/1/src/js/regexp.js#newcode168 src/js/regexp.js:168: function RegExpSubclassExecJS(string) { Rename to RegExpExecJS?
lgtm
Description was changed from ========== [regexp] Merge exec implementations RegExpSubclassExecJS and RegExpExecJS only differed in the additional TO_BOOLEAN on global and sticky flags and the useless (i < 0) check. R=littledan@chromium.org BUG= ========== to ========== [regexp] Merge exec implementations RegExpSubclassExecJS and RegExpExecJS only differed in the additional TO_BOOLEAN on global and sticky flags and the useless (i < 0) check. R=littledan@chromium.org BUG=v8:5339 ==========
The CQ bit was checked by jgruber@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2337763003 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by jgruber@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jgruber@chromium.org
https://codereview.chromium.org/2337923002/diff/1/src/js/regexp.js File src/js/regexp.js (right): https://codereview.chromium.org/2337923002/diff/1/src/js/regexp.js#newcode168 src/js/regexp.js:168: function RegExpSubclassExecJS(string) { On 2016/09/13 17:12:43, Dan Ehrenberg wrote: > Rename to RegExpExecJS? Done.
The CQ bit was checked by jgruber@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from littledan@chromium.org Link to the patchset: https://codereview.chromium.org/2337923002/#ps20001 (title: "Rename RegExpSubclassExecJS->RegExpExecJS")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [regexp] Merge exec implementations RegExpSubclassExecJS and RegExpExecJS only differed in the additional TO_BOOLEAN on global and sticky flags and the useless (i < 0) check. R=littledan@chromium.org BUG=v8:5339 ========== to ========== [regexp] Merge exec implementations RegExpSubclassExecJS and RegExpExecJS only differed in the additional TO_BOOLEAN on global and sticky flags and the useless (i < 0) check. R=littledan@chromium.org BUG=v8:5339 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [regexp] Merge exec implementations RegExpSubclassExecJS and RegExpExecJS only differed in the additional TO_BOOLEAN on global and sticky flags and the useless (i < 0) check. R=littledan@chromium.org BUG=v8:5339 ========== to ========== [regexp] Merge exec implementations RegExpSubclassExecJS and RegExpExecJS only differed in the additional TO_BOOLEAN on global and sticky flags and the useless (i < 0) check. R=littledan@chromium.org BUG=v8:5339 Committed: https://crrev.com/ee50e89b406cf5a247afccaf4d4c548f4b8f0523 Cr-Commit-Position: refs/heads/master@{#39417} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ee50e89b406cf5a247afccaf4d4c548f4b8f0523 Cr-Commit-Position: refs/heads/master@{#39417} |
