Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 2337913003: Fork cc::OutputSurface into cc::CompositorFrameSink. (Closed)
Patch Set: cfsfork: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_unittest.cc
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc
index b2ab289e122e09c577a7f4eee6049567c17579a9..636ec636a76e093a68871148c798bafea6050b08 100644
--- a/cc/trees/layer_tree_host_unittest.cc
+++ b/cc/trees/layer_tree_host_unittest.cc
@@ -49,7 +49,7 @@
#include "cc/test/layer_tree_test.h"
#include "cc/test/render_pass_test_utils.h"
#include "cc/test/skia_common.h"
-#include "cc/test/test_delegating_output_surface.h"
+#include "cc/test/test_compositor_frame_sink.h"
#include "cc/test/test_shared_bitmap_manager.h"
#include "cc/test/test_web_graphics_context_3d.h"
#include "cc/trees/effect_node.h"
@@ -435,7 +435,7 @@ SINGLE_THREAD_TEST_F(LayerTreeHostTestReadyToDrawVisibility);
class LayerTreeHostContextCacheTest : public LayerTreeHostTest {
public:
- std::unique_ptr<TestDelegatingOutputSurface> CreateDelegatingOutputSurface(
+ std::unique_ptr<TestCompositorFrameSink> CreateCompositorFrameSink(
scoped_refptr<ContextProvider> compositor_context_provider,
scoped_refptr<ContextProvider> worker_context_provider) override {
// Create the main ContextProvider with a MockContextSupport.
@@ -458,7 +458,7 @@ class LayerTreeHostContextCacheTest : public LayerTreeHostTest {
EXPECT_CALL(*mock_worker_context_support_,
SetAggressivelyFreeResources(false));
- return LayerTreeHostTest::CreateDelegatingOutputSurface(
+ return LayerTreeHostTest::CreateCompositorFrameSink(
std::move(test_main_context_provider),
std::move(test_worker_context_provider));
}
@@ -591,11 +591,11 @@ class LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated
SetAggressivelyFreeResources(true));
EXPECT_CALL(*mock_main_context_support_,
SetAggressivelyFreeResources(true));
- host_impl->DidLoseOutputSurface();
+ host_impl->DidLoseCompositorFrameSink();
has_recreated_ = true;
}
- void DidInitializeOutputSurface() override {
+ void DidInitializeCompositorFrameSink() override {
// This is run after we have recreated our OutputSurface.
if (!has_recreated_)
return;
@@ -2720,9 +2720,9 @@ class LayerTreeHostTestAbortedCommitDoesntStall : public LayerTreeHostTest {
int commit_complete_count_;
};
-class OnDrawOutputSurface : public TestDelegatingOutputSurface {
+class OnDrawCompositorFrameSink : public TestCompositorFrameSink {
public:
- explicit OnDrawOutputSurface(
+ explicit OnDrawCompositorFrameSink(
scoped_refptr<ContextProvider> compositor_context_provider,
scoped_refptr<ContextProvider> worker_context_provider,
std::unique_ptr<OutputSurface> display_output_surface,
@@ -2733,18 +2733,18 @@ class OnDrawOutputSurface : public TestDelegatingOutputSurface {
bool synchronous_composite,
bool force_disable_reclaim_resources,
base::Closure invalidate_callback)
- : TestDelegatingOutputSurface(std::move(compositor_context_provider),
- std::move(worker_context_provider),
- std::move(display_output_surface),
- shared_bitmap_manager,
- gpu_memory_buffer_manager,
- renderer_settings,
- task_runner,
- synchronous_composite,
- force_disable_reclaim_resources),
+ : TestCompositorFrameSink(std::move(compositor_context_provider),
+ std::move(worker_context_provider),
+ std::move(display_output_surface),
+ shared_bitmap_manager,
+ gpu_memory_buffer_manager,
+ renderer_settings,
+ task_runner,
+ synchronous_composite,
+ force_disable_reclaim_resources),
invalidate_callback_(std::move(invalidate_callback)) {}
- // TestDelegatingOutputSurface overrides.
+ // TestCompositorFrameSink overridCompositorFrameSink.
enne (OOO) 2016/09/14 00:35:45 @_@
void Invalidate() override { invalidate_callback_.Run(); }
void OnDraw(bool resourceless_software_draw) {
@@ -2765,14 +2765,14 @@ class LayerTreeHostTestAbortedCommitDoesntStallSynchronousCompositor
settings->using_synchronous_renderer_compositor = true;
}
- std::unique_ptr<TestDelegatingOutputSurface> CreateDelegatingOutputSurface(
+ std::unique_ptr<TestCompositorFrameSink> CreateCompositorFrameSink(
scoped_refptr<ContextProvider> compositor_context_provider,
scoped_refptr<ContextProvider> worker_context_provider) override {
auto on_draw_callback = base::Bind(
&LayerTreeHostTestAbortedCommitDoesntStallSynchronousCompositor::
CallOnDraw,
base::Unretained(this));
- auto output_surface = base::MakeUnique<OnDrawOutputSurface>(
+ auto output_surface = base::MakeUnique<OnDrawCompositorFrameSink>(
compositor_context_provider, std::move(worker_context_provider),
CreateDisplayOutputSurface(compositor_context_provider),
shared_bitmap_manager(), gpu_memory_buffer_manager(),
@@ -2790,13 +2790,13 @@ class LayerTreeHostTestAbortedCommitDoesntStallSynchronousCompositor
// surface. But it needs to be done on a new stack frame.
bool resourceless_software_draw = false;
ImplThreadTaskRunner()->PostTask(
- FROM_HERE, base::Bind(&OnDrawOutputSurface::OnDraw,
+ FROM_HERE, base::Bind(&OnDrawCompositorFrameSink::OnDraw,
base::Unretained(output_surface_),
resourceless_software_draw));
}
}
- OnDrawOutputSurface* output_surface_ = nullptr;
+ OnDrawCompositorFrameSink* output_surface_ = nullptr;
};
MULTI_THREAD_TEST_F(
@@ -2915,13 +2915,13 @@ class LayerTreeHostTestResourcelessSoftwareDraw : public LayerTreeHostTest {
client_.set_bounds(root_layer_->bounds());
}
- std::unique_ptr<TestDelegatingOutputSurface> CreateDelegatingOutputSurface(
+ std::unique_ptr<TestCompositorFrameSink> CreateCompositorFrameSink(
scoped_refptr<ContextProvider> compositor_context_provider,
scoped_refptr<ContextProvider> worker_context_provider) override {
auto on_draw_callback =
base::Bind(&LayerTreeHostTestResourcelessSoftwareDraw::CallOnDraw,
base::Unretained(this));
- auto output_surface = base::MakeUnique<OnDrawOutputSurface>(
+ auto output_surface = base::MakeUnique<OnDrawCompositorFrameSink>(
compositor_context_provider, std::move(worker_context_provider),
CreateDisplayOutputSurface(compositor_context_provider),
shared_bitmap_manager(), gpu_memory_buffer_manager(),
@@ -2941,7 +2941,7 @@ class LayerTreeHostTestResourcelessSoftwareDraw : public LayerTreeHostTest {
// surface. But it needs to be done on a new stack frame.
bool resourceless_software_draw = true;
ImplThreadTaskRunner()->PostTask(
- FROM_HERE, base::Bind(&OnDrawOutputSurface::OnDraw,
+ FROM_HERE, base::Bind(&OnDrawCompositorFrameSink::OnDraw,
base::Unretained(output_surface_),
resourceless_software_draw));
}
@@ -2983,7 +2983,7 @@ class LayerTreeHostTestResourcelessSoftwareDraw : public LayerTreeHostTest {
void AfterTest() override {}
private:
- OnDrawOutputSurface* output_surface_ = nullptr;
+ OnDrawCompositorFrameSink* output_surface_ = nullptr;
FakeContentLayerClient client_;
scoped_refptr<Layer> root_layer_;
scoped_refptr<Layer> parent_layer_;
@@ -3041,7 +3041,7 @@ class LayerTreeHostTestUIResource : public LayerTreeHostTest {
void DidActivateTreeOnThread(LayerTreeHostImpl* impl) override {
auto* context = static_cast<TestContextProvider*>(
- impl->output_surface()->context_provider())
+ impl->compositor_frame_sink()->context_provider())
->TestContext3d();
int frame = impl->active_tree()->source_frame_number();
@@ -5483,7 +5483,7 @@ class LayerTreeHostTestSynchronousCompositeSwapPromise
settings->use_zero_copy = true;
}
- std::unique_ptr<TestDelegatingOutputSurface> CreateDelegatingOutputSurface(
+ std::unique_ptr<TestCompositorFrameSink> CreateCompositorFrameSink(
scoped_refptr<ContextProvider> compositor_context_provider,
scoped_refptr<ContextProvider> worker_context_provider) override {
bool synchronous_composite =
@@ -5491,7 +5491,7 @@ class LayerTreeHostTestSynchronousCompositeSwapPromise
!layer_tree_host()->GetSettings().single_thread_proxy_scheduler;
// Relaiming resources is parameterized for this test.
bool force_disable_reclaim_resources = !reclaim_resources_;
- return base::MakeUnique<TestDelegatingOutputSurface>(
+ return base::MakeUnique<TestCompositorFrameSink>(
compositor_context_provider, std::move(worker_context_provider),
CreateDisplayOutputSurface(compositor_context_provider),
shared_bitmap_manager(), gpu_memory_buffer_manager(),
@@ -6947,7 +6947,7 @@ class GpuRasterizationSucceedsWithLargeImage : public LayerTreeHostTest {
// Retrieve max texture size from Skia.
ContextProvider* context_provider =
- host_impl->output_surface()->context_provider();
+ host_impl->compositor_frame_sink()->context_provider();
ASSERT_TRUE(context_provider);
ContextProvider::ScopedContextLock context_lock(context_provider);

Powered by Google App Engine
This is Rietveld 408576698