Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Side by Side Diff: blimp/client/app/compositor/browser_compositor.cc

Issue 2337913003: Fork cc::OutputSurface into cc::CompositorFrameSink. (Closed)
Patch Set: cfsfork: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/client/app/compositor/browser_compositor.h" 5 #include "blimp/client/app/compositor/browser_compositor.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/lazy_instance.h" 8 #include "base/lazy_instance.h"
9 #include "base/threading/thread_task_runner_handle.h" 9 #include "base/threading/thread_task_runner_handle.h"
10 #include "blimp/client/public/compositor/compositor_dependencies.h" 10 #include "blimp/client/public/compositor/compositor_dependencies.h"
11 #include "blimp/client/support/compositor/blimp_context_provider.h" 11 #include "blimp/client/support/compositor/blimp_context_provider.h"
12 #include "cc/animation/animation_host.h" 12 #include "cc/animation/animation_host.h"
13 #include "cc/layers/layer.h" 13 #include "cc/layers/layer.h"
14 #include "cc/output/compositor_frame.h" 14 #include "cc/output/compositor_frame.h"
15 #include "cc/output/output_surface.h"
15 #include "cc/output/texture_mailbox_deleter.h" 16 #include "cc/output/texture_mailbox_deleter.h"
16 #include "cc/raster/single_thread_task_graph_runner.h" 17 #include "cc/raster/single_thread_task_graph_runner.h"
18 #include "cc/surfaces/direct_compositor_frame_sink.h"
17 #include "cc/surfaces/display.h" 19 #include "cc/surfaces/display.h"
18 #include "cc/surfaces/surface_display_output_surface.h"
19 #include "cc/surfaces/surface_id_allocator.h" 20 #include "cc/surfaces/surface_id_allocator.h"
20 #include "cc/surfaces/surface_manager.h" 21 #include "cc/surfaces/surface_manager.h"
21 #include "cc/trees/layer_tree_host.h" 22 #include "cc/trees/layer_tree_host.h"
22 #include "gpu/command_buffer/client/context_support.h" 23 #include "gpu/command_buffer/client/context_support.h"
23 #include "gpu/command_buffer/client/gles2_lib.h" 24 #include "gpu/command_buffer/client/gles2_lib.h"
24 25
25 namespace blimp { 26 namespace blimp {
26 namespace client { 27 namespace client {
27 28
28 namespace { 29 namespace {
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 LAZY_INSTANCE_INITIALIZER; 67 LAZY_INSTANCE_INITIALIZER;
67 68
68 } // namespace 69 } // namespace
69 70
70 BrowserCompositor::BrowserCompositor( 71 BrowserCompositor::BrowserCompositor(
71 CompositorDependencies* compositor_dependencies) 72 CompositorDependencies* compositor_dependencies)
72 : compositor_dependencies_(compositor_dependencies), 73 : compositor_dependencies_(compositor_dependencies),
73 surface_id_allocator_(base::MakeUnique<cc::SurfaceIdAllocator>( 74 surface_id_allocator_(base::MakeUnique<cc::SurfaceIdAllocator>(
74 compositor_dependencies->AllocateSurfaceClientId())), 75 compositor_dependencies->AllocateSurfaceClientId())),
75 widget_(gfx::kNullAcceleratedWidget), 76 widget_(gfx::kNullAcceleratedWidget),
76 output_surface_request_pending_(false), 77 compositor_frame_sink_request_pending_(false),
77 root_layer_(cc::Layer::Create()) { 78 root_layer_(cc::Layer::Create()) {
78 compositor_dependencies_->GetSurfaceManager()->RegisterSurfaceClientId( 79 compositor_dependencies_->GetSurfaceManager()->RegisterSurfaceClientId(
79 surface_id_allocator_->client_id()); 80 surface_id_allocator_->client_id());
80 81
81 cc::LayerTreeHost::InitParams params; 82 cc::LayerTreeHost::InitParams params;
82 params.client = this; 83 params.client = this;
83 params.gpu_memory_buffer_manager = 84 params.gpu_memory_buffer_manager =
84 compositor_dependencies_->GetGpuMemoryBufferManager(); 85 compositor_dependencies_->GetGpuMemoryBufferManager();
85 params.task_graph_runner = g_task_graph_runner.Pointer(); 86 params.task_graph_runner = g_task_graph_runner.Pointer();
86 cc::LayerTreeSettings settings; 87 cc::LayerTreeSettings settings;
(...skipping 30 matching lines...) Expand all
117 display_->Resize(viewport_size_in_px_); 118 display_->Resize(viewport_size_in_px_);
118 } 119 }
119 } 120 }
120 121
121 void BrowserCompositor::SetAcceleratedWidget(gfx::AcceleratedWidget widget) { 122 void BrowserCompositor::SetAcceleratedWidget(gfx::AcceleratedWidget widget) {
122 // Kill all references to the old widget. 123 // Kill all references to the old widget.
123 if (widget_ != gfx::kNullAcceleratedWidget) { 124 if (widget_ != gfx::kNullAcceleratedWidget) {
124 // We are always visible if we have a widget. 125 // We are always visible if we have a widget.
125 DCHECK(host_->IsVisible()); 126 DCHECK(host_->IsVisible());
126 host_->SetVisible(false); 127 host_->SetVisible(false);
127 host_->ReleaseOutputSurface(); 128 host_->ReleaseCompositorFrameSink();
128 display_.reset(); 129 display_.reset();
129 } 130 }
130 131
131 widget_ = gfx::kNullAcceleratedWidget; 132 widget_ = gfx::kNullAcceleratedWidget;
132 133
133 if (widget != gfx::kNullAcceleratedWidget) { 134 if (widget != gfx::kNullAcceleratedWidget) {
134 widget_ = widget; 135 widget_ = widget;
135 host_->SetVisible(true); 136 host_->SetVisible(true);
136 if (output_surface_request_pending_) { 137 if (compositor_frame_sink_request_pending_) {
137 HandlePendingOutputSurfaceRequest(); 138 HandlePendingCompositorFrameSinkRequest();
138 } 139 }
139 } 140 }
140 } 141 }
141 142
142 void BrowserCompositor::RequestNewOutputSurface() { 143 void BrowserCompositor::RequestNewCompositorFrameSink() {
143 DCHECK(!output_surface_request_pending_) 144 DCHECK(!compositor_frame_sink_request_pending_)
144 << "We already have a pending request?"; 145 << "We already have a pending request?";
145 output_surface_request_pending_ = true; 146 compositor_frame_sink_request_pending_ = true;
146 HandlePendingOutputSurfaceRequest(); 147 HandlePendingCompositorFrameSinkRequest();
147 } 148 }
148 149
149 void BrowserCompositor::DidInitializeOutputSurface() { 150 void BrowserCompositor::DidInitializeCompositorFrameSink() {
150 output_surface_request_pending_ = false; 151 compositor_frame_sink_request_pending_ = false;
151 } 152 }
152 153
153 void BrowserCompositor::DidFailToInitializeOutputSurface() { 154 void BrowserCompositor::DidFailToInitializeCompositorFrameSink() {
154 NOTREACHED() << "Can't fail to initialize the OutputSurface here"; 155 NOTREACHED() << "Can't fail to initialize the CompositorFrameSink here";
155 } 156 }
156 157
157 void BrowserCompositor::DidCompleteSwapBuffers() { 158 void BrowserCompositor::DidCompleteSwapBuffers() {
158 if (!did_complete_swap_buffers_.is_null()) { 159 if (!did_complete_swap_buffers_.is_null()) {
159 did_complete_swap_buffers_.Run(); 160 did_complete_swap_buffers_.Run();
160 } 161 }
161 } 162 }
162 163
163 void BrowserCompositor::HandlePendingOutputSurfaceRequest() { 164 void BrowserCompositor::HandlePendingCompositorFrameSinkRequest() {
164 DCHECK(output_surface_request_pending_); 165 DCHECK(compositor_frame_sink_request_pending_);
165 166
166 // Can't handle the request right now since we don't have a widget. 167 // Can't handle the request right now since we don't have a widget.
167 if (!host_->IsVisible()) 168 if (!host_->IsVisible())
168 return; 169 return;
169 170
170 DCHECK_NE(gfx::kNullAcceleratedWidget, widget_); 171 DCHECK_NE(gfx::kNullAcceleratedWidget, widget_);
171 172
172 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager = 173 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager =
173 compositor_dependencies_->GetGpuMemoryBufferManager(); 174 compositor_dependencies_->GetGpuMemoryBufferManager();
174 175
175 scoped_refptr<cc::ContextProvider> context_provider = 176 scoped_refptr<cc::ContextProvider> context_provider =
176 BlimpContextProvider::Create(widget_, gpu_memory_buffer_manager); 177 BlimpContextProvider::Create(widget_, gpu_memory_buffer_manager);
177 178
178 std::unique_ptr<cc::OutputSurface> display_output_surface = 179 std::unique_ptr<cc::OutputSurface> output_surface =
179 base::MakeUnique<DisplayOutputSurface>(context_provider); 180 base::MakeUnique<DisplayOutputSurface>(context_provider);
180 181
181 auto* task_runner = base::ThreadTaskRunnerHandle::Get().get(); 182 auto* task_runner = base::ThreadTaskRunnerHandle::Get().get();
182 std::unique_ptr<cc::SyntheticBeginFrameSource> begin_frame_source( 183 std::unique_ptr<cc::SyntheticBeginFrameSource> begin_frame_source(
183 new cc::DelayBasedBeginFrameSource( 184 new cc::DelayBasedBeginFrameSource(
184 base::MakeUnique<cc::DelayBasedTimeSource>(task_runner))); 185 base::MakeUnique<cc::DelayBasedTimeSource>(task_runner)));
185 std::unique_ptr<cc::DisplayScheduler> scheduler(new cc::DisplayScheduler( 186 std::unique_ptr<cc::DisplayScheduler> scheduler(new cc::DisplayScheduler(
186 begin_frame_source.get(), task_runner, 187 begin_frame_source.get(), task_runner,
187 display_output_surface->capabilities().max_frames_pending)); 188 output_surface->capabilities().max_frames_pending));
188 189
189 display_ = base::MakeUnique<cc::Display>( 190 display_ = base::MakeUnique<cc::Display>(
190 nullptr /*shared_bitmap_manager*/, gpu_memory_buffer_manager, 191 nullptr /*shared_bitmap_manager*/, gpu_memory_buffer_manager,
191 host_->GetSettings().renderer_settings, std::move(begin_frame_source), 192 host_->GetSettings().renderer_settings, std::move(begin_frame_source),
192 std::move(display_output_surface), std::move(scheduler), 193 std::move(output_surface), std::move(scheduler),
193 base::MakeUnique<cc::TextureMailboxDeleter>(task_runner)); 194 base::MakeUnique<cc::TextureMailboxDeleter>(task_runner));
194 display_->SetVisible(true); 195 display_->SetVisible(true);
195 display_->Resize(viewport_size_in_px_); 196 display_->Resize(viewport_size_in_px_);
196 197
197 // The Browser compositor and display share the same context provider. 198 // The browser's layer tree and display compositors share the same context
198 std::unique_ptr<cc::OutputSurface> delegated_output_surface = 199 // provider.
199 base::MakeUnique<cc::SurfaceDisplayOutputSurface>( 200 auto compositor_frame_sink = base::MakeUnique<cc::DirectCompositorFrameSink>(
200 compositor_dependencies_->GetSurfaceManager(), 201 compositor_dependencies_->GetSurfaceManager(),
201 surface_id_allocator_.get(), display_.get(), context_provider, 202 surface_id_allocator_.get(), display_.get(), context_provider, nullptr);
202 nullptr);
203 203
204 host_->SetOutputSurface(std::move(delegated_output_surface)); 204 host_->SetCompositorFrameSink(std::move(compositor_frame_sink));
205 } 205 }
206 206
207 } // namespace client 207 } // namespace client
208 } // namespace blimp 208 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698