content/common/media/midi_messages.h - Issue 23379002: Web MIDI: fix multi-threading problem around message buffer handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/media/midi_messages.h

Issue 23379002: Web MIDI: fix multi-threading problem around message buffer handling (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review #12 (for submmit) Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/media/midi_messages.h

diff --git a/content/common/media/midi_messages.h b/content/common/media/midi_messages.h

index 86e5c16d690244aa3dcafd82ddf23695d1524e3d..bff0241fe4fd6dd653d9d9bc458a0d5e80000aab 100644

--- a/content/common/media/midi_messages.h

+++ b/content/common/media/midi_messages.h

@@ -43,7 +43,7 @@ IPC_MESSAGE_CONTROL1(MIDIHostMsg_StartSession,

int /* client id */)

IPC_MESSAGE_CONTROL3(MIDIHostMsg_SendData,

- int /* port */,

+ uint32 /* port */,

std::vector<uint8> /* data */,

double /* timestamp */)

@@ -56,9 +56,9 @@ IPC_MESSAGE_CONTROL4(MIDIMsg_SessionStarted,

media::MIDIPortInfoList /* output ports */)

IPC_MESSAGE_CONTROL3(MIDIMsg_DataReceived,

- int /* port */,

+ uint32 /* port */,

std::vector<uint8> /* data */,

double /* timestamp */)

IPC_MESSAGE_CONTROL1(MIDIMsg_AcknowledgeSentData,

- size_t /* bytes sent */)

+ uint32 /* bytes sent */)