Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: content/renderer/media/midi_message_filter.h

Issue 23379002: Web MIDI: fix multi-threading problem around message buffer handling (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review #7 and #8 Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/midi_message_filter.h
diff --git a/content/renderer/media/midi_message_filter.h b/content/renderer/media/midi_message_filter.h
index cf969e9d8078401a5de3b665b4a0ddfcae4a571f..902d21125f3b3c4139d74096c92ff0cf7dbe4abc 100644
--- a/content/renderer/media/midi_message_filter.h
+++ b/content/renderer/media/midi_message_filter.h
@@ -12,7 +12,6 @@
#include "content/common/content_export.h"
#include "ipc/ipc_channel_proxy.h"
#include "media/midi/midi_port_info.h"
-#include "third_party/WebKit/public/platform/WebMIDIAccessor.h"
#include "third_party/WebKit/public/platform/WebMIDIAccessorClient.h"
namespace base {
@@ -37,7 +36,7 @@ class CONTENT_EXPORT MIDIMessageFilter
// A client will only be able to call this method if it has a suitable
// output port (from addOutputPort()).
- void SendMIDIData(int port,
+ void SendMIDIData(size_t port,
palmer 2013/08/26 17:43:25 Define this to be uint32_t.
Takashi Toyoshima 2013/08/27 07:14:33 Done.
const uint8* data,
size_t length,
double timestamp);
@@ -89,7 +88,7 @@ class CONTENT_EXPORT MIDIMessageFilter
void StartSessionOnIOThread(int client_id);
- void SendMIDIDataOnIOThread(int port,
+ void SendMIDIDataOnIOThread(size_t port,
palmer 2013/08/26 17:43:25 Define this to be uint32_t.
Takashi Toyoshima 2013/08/27 07:14:33 Done.
const std::vector<uint8>& data,
double timestamp);

Powered by Google App Engine
This is Rietveld 408576698