Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: media/midi/midi_manager_mac.h

Issue 23379002: Web MIDI: fix multi-threading problem around message buffer handling (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: s/CHECK/DCHECK/ Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/midi/midi_manager_mac.h
diff --git a/media/midi/midi_manager_mac.h b/media/midi/midi_manager_mac.h
index ed7b524f5c4d7060de80c0b544ddceb54a8f2e1d..58e92b1b63a4390a5f2716fa4256f2030783c53a 100644
--- a/media/midi/midi_manager_mac.h
+++ b/media/midi/midi_manager_mac.h
@@ -8,6 +8,7 @@
#include <CoreMIDI/MIDIServices.h>
#include <map>
#include <string>
+#include <vector>
#include "base/basictypes.h"
#include "base/compiler_specific.h"
@@ -24,9 +25,8 @@ class MEDIA_EXPORT MIDIManagerMac : public MIDIManager {
// MIDIManager implementation.
virtual bool Initialize() OVERRIDE;
virtual void SendMIDIData(MIDIManagerClient* client,
- int port_index,
- const uint8* data,
- size_t length,
+ unsigned int port_index,
scherkus (not reviewing) 2013/08/21 17:46:29 nit: while unsigned is prevalent in blink, this sh
Takashi Toyoshima 2013/08/22 05:47:45 Done.
palmer 2013/08/22 18:25:41 There is a fun thing here. It can often make sense
+ const std::vector<uint8>& data,
double timestamp) OVERRIDE;
private:

Powered by Google App Engine
This is Rietveld 408576698