Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2337893003: Pass PopularSites ownership to MostVisitedSites. (Closed)

Created:
4 years, 3 months ago by sfiera
Modified:
4 years, 3 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass PopularSites ownership to MostVisitedSites. Nothing outside of MostVisitedSites needs to use it. Committed: https://crrev.com/96c03256ee91d7c1654051b2a0520408196bdd79 Cr-Commit-Position: refs/heads/master@{#418625}

Patch Set 1 #

Patch Set 2 : header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M chrome/browser/android/ntp/most_visited_sites_bridge.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/ntp/most_visited_sites_bridge.cc View 1 2 chunks +9 lines, -8 lines 0 comments Download
M components/ntp_tiles/most_visited_sites.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/ntp_tiles/most_visited_sites.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
sfiera
4 years, 3 months ago (2016-09-13 23:34:17 UTC) #4
Marc Treib
LGTM
4 years, 3 months ago (2016-09-14 08:51:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337893003/40001
4 years, 3 months ago (2016-09-14 18:52:09 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-09-14 18:58:40 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 19:00:56 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/96c03256ee91d7c1654051b2a0520408196bdd79
Cr-Commit-Position: refs/heads/master@{#418625}

Powered by Google App Engine
This is Rietveld 408576698