Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2337893002: dbus: Remove dbus::FileDescriptor (Closed)

Created:
4 years, 3 months ago by hashimoto
Modified:
4 years, 3 months ago
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

dbus: Remove dbus::FileDescriptor BUG=621841 TEST=dbus_unittests TBR=steel@chromium.org for device/bluetooth/dbus Committed: https://crrev.com/dc693afc916d0596e07a0529f162516475c466f3 Cr-Commit-Position: refs/heads/master@{#418481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -219 lines) Patch
M chromeos/dbus/fake_permission_broker_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/mock_permission_broker_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/network/firewall_hole_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M dbus/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D dbus/file_descriptor.h View 1 chunk +0 lines, -92 lines 0 comments Download
D dbus/file_descriptor.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M dbus/message.h View 3 chunks +0 lines, -9 lines 0 comments Download
M dbus/message.cc View 3 chunks +2 lines, -26 lines 0 comments Download
M dbus/message_unittest.cc View 1 chunk +6 lines, -15 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_le_advertisement_service_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_le_advertisement_service_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_media_transport_client.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
hashimoto
4 years, 3 months ago (2016-09-13 09:17:10 UTC) #4
stevenjb
Hooray, thanks for doing this cleanup! LGTM
4 years, 3 months ago (2016-09-13 15:23:25 UTC) #7
satorux1
lgtm
4 years, 3 months ago (2016-09-14 00:14:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337893002/1
4 years, 3 months ago (2016-09-14 03:25:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/258981)
4 years, 3 months ago (2016-09-14 03:32:55 UTC) #12
hashimoto
TBRing steel@chromium.org for include deletion in device/bluetooth/dbus
4 years, 3 months ago (2016-09-14 03:43:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337893002/1
4 years, 3 months ago (2016-09-14 03:44:12 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 04:05:21 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 04:06:59 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc693afc916d0596e07a0529f162516475c466f3
Cr-Commit-Position: refs/heads/master@{#418481}

Powered by Google App Engine
This is Rietveld 408576698