Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2337873002: Revert cookies back to be domain scoped (Closed)

Created:
4 years, 3 months ago by lshang
Modified:
4 years, 3 months ago
Reviewers:
msramek, raymes
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert cookies back to be domain scoped Revert cookie scoping back to domain-based. BUG=645745 Committed: https://crrev.com/88f013bd979ec30333bd7ce6c0bd2e0b5f6f2742 Cr-Commit-Position: refs/heads/master@{#418233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M chrome/browser/browsing_data/cookies_tree_model_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M components/content_settings/core/browser/content_settings_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/host_content_settings_map.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/content_settings/core/browser/website_settings_info.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
lshang
PTAL thanks!
4 years, 3 months ago (2016-09-13 01:28:28 UTC) #5
raymes
lgtm
4 years, 3 months ago (2016-09-13 01:34:28 UTC) #6
msramek
LGTM
4 years, 3 months ago (2016-09-13 13:48:50 UTC) #9
msramek
As with the previous revert on this topic (https://codereview.chromium.org/2213313002/), I'll take the liberty to CQ ...
4 years, 3 months ago (2016-09-13 14:03:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337873002/1
4 years, 3 months ago (2016-09-13 14:03:58 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 14:08:42 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 14:10:17 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88f013bd979ec30333bd7ce6c0bd2e0b5f6f2742
Cr-Commit-Position: refs/heads/master@{#418233}

Powered by Google App Engine
This is Rietveld 408576698