Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: gpu/command_buffer/service/feature_info_unittest.cc

Issue 2337833002: Implement WEBGL_compressed_texture_s3tc_srgb (Closed)
Patch Set: add test and fix feature detection (enabled on webgl2, android/tegra) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/feature_info.h" 5 #include "gpu/command_buffer/service/feature_info.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 EXPECT_THAT(info_->extensions(), 284 EXPECT_THAT(info_->extensions(),
285 Not(HasSubstr("GL_ANGLE_texture_usage"))); 285 Not(HasSubstr("GL_ANGLE_texture_usage")));
286 EXPECT_THAT(info_->extensions(), 286 EXPECT_THAT(info_->extensions(),
287 Not(HasSubstr("GL_EXT_texture_storage"))); 287 Not(HasSubstr("GL_EXT_texture_storage")));
288 EXPECT_THAT(info_->extensions(), 288 EXPECT_THAT(info_->extensions(),
289 Not(HasSubstr("GL_OES_compressed_ETC1_RGB8_texture"))); 289 Not(HasSubstr("GL_OES_compressed_ETC1_RGB8_texture")));
290 EXPECT_THAT(info_->extensions(), 290 EXPECT_THAT(info_->extensions(),
291 Not(HasSubstr("GL_AMD_compressed_ATC_texture"))); 291 Not(HasSubstr("GL_AMD_compressed_ATC_texture")));
292 EXPECT_THAT(info_->extensions(), 292 EXPECT_THAT(info_->extensions(),
293 Not(HasSubstr("GL_IMG_texture_compression_pvrtc"))); 293 Not(HasSubstr("GL_IMG_texture_compression_pvrtc")));
294 EXPECT_THAT(info_->extensions(),
295 Not(HasSubstr("GL_EXT_texture_compression_s3tc_srgb")));
294 EXPECT_FALSE(info_->feature_flags().npot_ok); 296 EXPECT_FALSE(info_->feature_flags().npot_ok);
295 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid( 297 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
296 GL_COMPRESSED_RGB_S3TC_DXT1_EXT)); 298 GL_COMPRESSED_RGB_S3TC_DXT1_EXT));
297 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid( 299 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
298 GL_COMPRESSED_RGBA_S3TC_DXT1_EXT)); 300 GL_COMPRESSED_RGBA_S3TC_DXT1_EXT));
299 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid( 301 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
300 GL_COMPRESSED_RGBA_S3TC_DXT3_EXT)); 302 GL_COMPRESSED_RGBA_S3TC_DXT3_EXT));
301 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid( 303 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
302 GL_COMPRESSED_RGBA_S3TC_DXT5_EXT)); 304 GL_COMPRESSED_RGBA_S3TC_DXT5_EXT));
303 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid( 305 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
306 GL_COMPRESSED_SRGB_S3TC_DXT1_EXT));
307 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
308 GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT1_EXT));
309 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
310 GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT3_EXT));
311 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
312 GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT5_EXT));
313 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
304 GL_ETC1_RGB8_OES)); 314 GL_ETC1_RGB8_OES));
305 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid( 315 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
306 GL_ATC_RGB_AMD)); 316 GL_ATC_RGB_AMD));
307 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid( 317 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
308 GL_ATC_RGBA_EXPLICIT_ALPHA_AMD)); 318 GL_ATC_RGBA_EXPLICIT_ALPHA_AMD));
309 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid( 319 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
310 GL_ATC_RGBA_INTERPOLATED_ALPHA_AMD)); 320 GL_ATC_RGBA_INTERPOLATED_ALPHA_AMD));
311 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid( 321 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
312 GL_COMPRESSED_RGB_PVRTC_4BPPV1_IMG)); 322 GL_COMPRESSED_RGB_PVRTC_4BPPV1_IMG));
313 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid( 323 EXPECT_FALSE(info_->validators()->compressed_texture_format.IsValid(
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
403 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid( 413 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid(
404 GL_COMPRESSED_RGB_S3TC_DXT1_EXT)); 414 GL_COMPRESSED_RGB_S3TC_DXT1_EXT));
405 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid( 415 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid(
406 GL_COMPRESSED_RGBA_S3TC_DXT1_EXT)); 416 GL_COMPRESSED_RGBA_S3TC_DXT1_EXT));
407 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid( 417 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid(
408 GL_COMPRESSED_RGBA_S3TC_DXT3_EXT)); 418 GL_COMPRESSED_RGBA_S3TC_DXT3_EXT));
409 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid( 419 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid(
410 GL_COMPRESSED_RGBA_S3TC_DXT5_EXT)); 420 GL_COMPRESSED_RGBA_S3TC_DXT5_EXT));
411 } 421 }
412 422
423 TEST_P(FeatureInfoTest, InitializeEXT_texture_compression_s3tc_srgb) {
424 SetupInitExpectationsWithGLVersion("GL_NV_sRGB_formats", "",
425 "OpenGL ES 2.0");
426 EXPECT_THAT(info_->extensions(),
427 HasSubstr("GL_EXT_texture_compression_s3tc_srgb"));
428 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid(
429 GL_COMPRESSED_SRGB_S3TC_DXT1_EXT));
430 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid(
431 GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT1_EXT));
432 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid(
433 GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT3_EXT));
434 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid(
435 GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT5_EXT));
436 }
437
438 TEST_P(FeatureInfoTest, InitializeEXT_texture_compression_s3tc_srgbGL) {
439 SetupInitExpectations("GL_EXT_texture_sRGB GL_EXT_texture_compression_s3tc");
440 EXPECT_THAT(info_->extensions(),
441 HasSubstr("GL_EXT_texture_compression_s3tc_srgb"));
442 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid(
443 GL_COMPRESSED_SRGB_S3TC_DXT1_EXT));
444 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid(
445 GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT1_EXT));
446 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid(
447 GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT3_EXT));
448 EXPECT_TRUE(info_->validators()->compressed_texture_format.IsValid(
449 GL_COMPRESSED_SRGB_ALPHA_S3TC_DXT5_EXT));
450 }
451
413 TEST_P(FeatureInfoTest, InitializeEXT_texture_format_BGRA8888GLES2) { 452 TEST_P(FeatureInfoTest, InitializeEXT_texture_format_BGRA8888GLES2) {
414 SetupInitExpectationsWithGLVersion("GL_EXT_texture_format_BGRA8888", "", 453 SetupInitExpectationsWithGLVersion("GL_EXT_texture_format_BGRA8888", "",
415 "OpenGL ES 2.0"); 454 "OpenGL ES 2.0");
416 EXPECT_THAT(info_->extensions(), 455 EXPECT_THAT(info_->extensions(),
417 HasSubstr("GL_EXT_texture_format_BGRA8888")); 456 HasSubstr("GL_EXT_texture_format_BGRA8888"));
418 EXPECT_TRUE(info_->validators()->texture_format.IsValid( 457 EXPECT_TRUE(info_->validators()->texture_format.IsValid(
419 GL_BGRA_EXT)); 458 GL_BGRA_EXT));
420 EXPECT_TRUE(info_->validators()->texture_internal_format.IsValid( 459 EXPECT_TRUE(info_->validators()->texture_internal_format.IsValid(
421 GL_BGRA_EXT)); 460 GL_BGRA_EXT));
422 461
(...skipping 1129 matching lines...) Expand 10 before | Expand all | Expand 10 after
1552 EXPECT_TRUE(info_->validators()->render_buffer_format.IsValid(GL_RG8_EXT)); 1591 EXPECT_TRUE(info_->validators()->render_buffer_format.IsValid(GL_RG8_EXT));
1553 } 1592 }
1554 1593
1555 TEST_P(FeatureInfoTest, InitializeCHROMIUM_ycbcr_422_imageTrue) { 1594 TEST_P(FeatureInfoTest, InitializeCHROMIUM_ycbcr_422_imageTrue) {
1556 SetupInitExpectations("GL_APPLE_ycbcr_422"); 1595 SetupInitExpectations("GL_APPLE_ycbcr_422");
1557 EXPECT_TRUE(info_->feature_flags().chromium_image_ycbcr_422); 1596 EXPECT_TRUE(info_->feature_flags().chromium_image_ycbcr_422);
1558 } 1597 }
1559 1598
1560 } // namespace gles2 1599 } // namespace gles2
1561 } // namespace gpu 1600 } // namespace gpu
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698