Fix SSLUITest.TestGoodFrameNavigation with PlzNavigate.

Fix SSLUITest.TestGoodFrameNavigation with PlzNavigate.

The problem was that this test was checking that it got the notification that insecure content was run. Without PlzNavigate, this notification was sent from the renderer before it starts loading the url (http://example.test/...). The content never actually loaded, because browser tests have a resolver that block all network requests to the outside world in order to avoid flaky tests which make network requests. With PlzNavigate, the request was being cancelled in the browser process and the renderer never got as far to be told that insecure content was run.

The fix is to just the browser test to treat example.test as a local host. A small side effect is that it now also loads the image in that page, so we need to tweak the test to reflect that the page both loads and displays insecure content.

BUG=504347
Committed: https://crrev.com/2a251cde325405c47fce08fb57ee771b95406ccb
Cr-Commit-Position: refs/heads/master@{#418112}

[jam, 2016-09-12 23:11:29]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2016-09-12 23:12:10]

jam@chromium.org changed reviewers:
+ scottmg@chromium.org

[commit-bot: I haz the power, 2016-09-12 23:12:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-09-12 23:13:30]

lgtm

https://codereview.chromium.org/2337793002/diff/1/chrome/browser/ssl/ssl_brow...
File chrome/browser/ssl/ssl_browser_tests.cc (right):

https://codereview.chromium.org/2337793002/diff/1/chrome/browser/ssl/ssl_brow...
chrome/browser/ssl/ssl_browser_tests.cc:2206: // this also displayed images from
the http page (google.com).
displayed -> displays

[jam, 2016-09-12 23:21:54]

https://codereview.chromium.org/2337793002/diff/1/chrome/browser/ssl/ssl_brow...
File chrome/browser/ssl/ssl_browser_tests.cc (right):

https://codereview.chromium.org/2337793002/diff/1/chrome/browser/ssl/ssl_brow...
chrome/browser/ssl/ssl_browser_tests.cc:2206: // this also displayed images from
the http page (google.com).
On 2016/09/12 23:13:30, scottmg wrote:
> displayed -> displays

Done.

[jam, 2016-09-12 23:21:58]

The CQ bit was checked by jam@chromium.org

[jam, 2016-09-12 23:21:58]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2337793002/#ps20001
(title: "review comment")

[commit-bot: I haz the power, 2016-09-12 23:22:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 00:05:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-13 00:08:04]

Description was changed from

==========
Fix SSLUITest.TestGoodFrameNavigation with PlzNavigate.

The problem was that this test was checking that it got the notification that
insecure content was run. Without PlzNavigate, this notification was sent from
the renderer before it starts loading the url (http://example.test/...). The
content never actually loaded, because browser tests have a resolver that block
all network requests to the outside world in order to avoid flaky tests which
make network requests. With PlzNavigate, the request was being cancelled in the
browser process and the renderer never got as far to be told that insecure
content was run.

The fix is to just the browser test to treat example.test as a local host. A
small side effect is that it now also loads the image in that page, so we need
to tweak the test to reflect that the page both loads and displays insecure
content.

BUG=504347
==========

to

==========
Fix SSLUITest.TestGoodFrameNavigation with PlzNavigate.

The problem was that this test was checking that it got the notification that
insecure content was run. Without PlzNavigate, this notification was sent from
the renderer before it starts loading the url (http://example.test/...). The
content never actually loaded, because browser tests have a resolver that block
all network requests to the outside world in order to avoid flaky tests which
make network requests. With PlzNavigate, the request was being cancelled in the
browser process and the renderer never got as far to be told that insecure
content was run.

The fix is to just the browser test to treat example.test as a local host. A
small side effect is that it now also loads the image in that page, so we need
to tweak the test to reflect that the page both loads and displays insecure
content.

BUG=504347

Committed: https://crrev.com/2a251cde325405c47fce08fb57ee771b95406ccb
Cr-Commit-Position: refs/heads/master@{#418112}
==========

[commit-bot: I haz the power, 2016-09-13 00:08:07]

Patchset 2 (id:??) landed as
https://crrev.com/2a251cde325405c47fce08fb57ee771b95406ccb
Cr-Commit-Position: refs/heads/master@{#418112}

[carlosk, 2016-09-13 17:24:10]

On 2016/09/13 00:08:07, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/2a251cde325405c47fce08fb57ee771b95406ccb
> Cr-Commit-Position: refs/heads/master@{#418112}

FYI this behavior might change once I land the partial move of mixed content
checks to the browser (https://crrev.com/1905033002).