Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2337783005: Fix crash when displaying a null certificate. (Closed)

Created:
4 years, 3 months ago by jam
Modified:
4 years, 3 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when displaying a null certificate. This regressed in r417444. Previously (https://codereview.chromium.org/2327433002/diff/250001/chrome/browser/certificate_viewer.cc) we would check that the certificate id sent by the renderer was valid (say because renderer died). Races could also happen now, in that the page might navigate right after user presses certificate viewer button and the last committed entry wouldn't have a certificate. BUG=646882 Committed: https://crrev.com/86e4f0c45cb22e575d7c5a373ebe40c66ec1f2eb Cr-Commit-Position: refs/heads/master@{#418644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/devtools/protocol/security_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jam
4 years, 3 months ago (2016-09-14 17:45:49 UTC) #4
pfeldman
lgtm
4 years, 3 months ago (2016-09-14 19:30:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337783005/1
4 years, 3 months ago (2016-09-14 19:36:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 19:43:12 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 19:44:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86e4f0c45cb22e575d7c5a373ebe40c66ec1f2eb
Cr-Commit-Position: refs/heads/master@{#418644}

Powered by Google App Engine
This is Rietveld 408576698