Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2337783004: Fix the wrong candidate window on Mac OSX. (Closed)

Created:
4 years, 3 months ago by Seigo Nonaka
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix the wrong candidate window on Mac OSX. After http://crrev.com/dac0c7af14c29c9d8509b775d5044e5448b6263b, renderer no longer capturing the composition bounds by default. To receive the latest composition bounds from renderer, we need to update the monitor state and it was done for aura platform in above CL. This CL introduces the similar logic to RWHVM to fix the wrong candidate window issue. BUG=639552 Review-Url: https://codereview.chromium.org/2296623002 Cr-Commit-Position: refs/heads/master@{#417877} (cherry picked from commit fbd66b59cd50bacb823d7aeb6396f32594583fb1) Committed: https://chromium.googlesource.com/chromium/src/+/3c0e829d4ed12936c68a34ec918acaf4d9f7c0ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Seigo Nonaka
4 years, 3 months ago (2016-09-14 05:58:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c0e829d4ed12936c68a34ec918acaf4d9f7c0ef.

Powered by Google App Engine
This is Rietveld 408576698