[Extensions DocServer] Update Server for new Datastore API

[Extensions DocServer] Update Server for new Datastore API

The Cloud Datastore API is being updated. Update server2 to match.
Release notes for the API:
https://cloud.google.com/datastore/release-notes

BUG=646877
Committed: https://crrev.com/48fff61eb0853269f41db74ef5e5ee432e1beed5
Cr-Commit-Position: refs/heads/master@{#418572}

[Devlin, 2016-09-12 22:36:55]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 22:37:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 23:18:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 23:18:46]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-09-13 00:28:00]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org, rockot@chromium.org

[Devlin, 2016-09-13 00:28:00]

Antony, mind taking a look?  Ken, can you double check that this seems sane?

[Ken Rockot(use gerrit already), 2016-09-13 01:28:48]

I don't notice anything missing vs the release notes, so LGTM!

[asargent_no_longer_on_chrome, 2016-09-14 04:57:57]

lgtm

https://codereview.chromium.org/2337753002/diff/1/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/datastore_util.py (right):

https://codereview.chromium.org/2337753002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/datastore_util.py:19: _VALUE_PROPERTY_NAME
= 'pickled_value'
random aside: this style of having variables for these 3 instead of just
directly using the string seems kind of strange to me. Especially since 2 of
them only appear once in the file. 

Unless there's some compelling reason to have them that I'm not seeing, a future
cleanup could improve readability IMHO by inlining these strings.

[Devlin, 2016-09-14 15:03:50]

Description was changed from

==========
[Extensions DocServer] Update Server for new Datastore API

The Cloud Datastore API is being updated. Update server2 to match.
Release notes for the API:
https://cloud.google.com/datastore/release-notes

BUG=
==========

to

==========
[Extensions DocServer] Update Server for new Datastore API

The Cloud Datastore API is being updated. Update server2 to match.
Release notes for the API:
https://cloud.google.com/datastore/release-notes

BUG=646877
==========

[Devlin, 2016-09-14 15:09:24]

https://codereview.chromium.org/2337753002/diff/1/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/datastore_util.py (right):

https://codereview.chromium.org/2337753002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/datastore_util.py:19: _VALUE_PROPERTY_NAME
= 'pickled_value'
On 2016/09/14 04:57:57, Antony Sargent wrote:
> random aside: this style of having variables for these 3 instead of just
> directly using the string seems kind of strange to me. Especially since 2 of
> them only appear once in the file. 
> 
> Unless there's some compelling reason to have them that I'm not seeing, a
future
> cleanup could improve readability IMHO by inlining these strings. 
>  

For this particular case (property name), the reason to have a variable is to
avoid a typo in one of the three occurrences, which I think is pretty valid. 
For the other two, I would normally think it's a way of having self-documenting
variables (e.g. bool flag_x = false; DoFoo(flag_x) is more readable than
DoFoo(false)), but in both of these cases, it's pretty obvious from the context
what it is, so I agree that inlining sg.  I'll do that in a followup.

[Devlin, 2016-09-14 15:09:29]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-09-14 15:09:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 15:45:08]

Description was changed from

==========
[Extensions DocServer] Update Server for new Datastore API

The Cloud Datastore API is being updated. Update server2 to match.
Release notes for the API:
https://cloud.google.com/datastore/release-notes

BUG=646877
==========

to

==========
[Extensions DocServer] Update Server for new Datastore API

The Cloud Datastore API is being updated. Update server2 to match.
Release notes for the API:
https://cloud.google.com/datastore/release-notes

BUG=646877
==========

[commit-bot: I haz the power, 2016-09-14 15:45:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-14 15:47:36]

Description was changed from

==========
[Extensions DocServer] Update Server for new Datastore API

The Cloud Datastore API is being updated. Update server2 to match.
Release notes for the API:
https://cloud.google.com/datastore/release-notes

BUG=646877
==========

to

==========
[Extensions DocServer] Update Server for new Datastore API

The Cloud Datastore API is being updated. Update server2 to match.
Release notes for the API:
https://cloud.google.com/datastore/release-notes

BUG=646877

Committed: https://crrev.com/48fff61eb0853269f41db74ef5e5ee432e1beed5
Cr-Commit-Position: refs/heads/master@{#418572}
==========

[commit-bot: I haz the power, 2016-09-14 15:47:37]

Patchset 1 (id:??) landed as
https://crrev.com/48fff61eb0853269f41db74ef5e5ee432e1beed5
Cr-Commit-Position: refs/heads/master@{#418572}