Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2337733002: [tracing] Support BACKGROUND mode in MemoryCache dump provider (Closed)

Created:
4 years, 3 months ago by ssid
Modified:
4 years, 2 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, wfh+watch_chromium.org, Yoav Weiss, blink-reviews, gavinp+loader_chromium.org, tracing+reviews_chromium.org, loading-reviews+fetch_chromium.org, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Support BACKGROUND mode in MemoryCache dump provider This CL adds support for BACKGROUND mode in MemoryCache dump provider, where it just adds the total sizes of resources (given by encodedSize of each resource). This CL also fixes the image resources reporting which had a shared buffer that was not reported in the ImageResource subclass. It also fixes the SharedBuffer::onMemoryDump to dump when both shared buffer and segments are used together. BUG=629925 Committed: https://crrev.com/203b334b85d015fb651010ba89e6c6f31bae2b2e Cr-Commit-Position: refs/heads/master@{#418957}

Patch Set 1 #

Patch Set 2 : remove trace_event change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M third_party/WebKit/Source/core/fetch/ImageResource.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCache.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/MemoryCache.cpp View 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/MemoryCacheDumpProvider.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/SharedBuffer.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/web_process_memory_dump.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
ssid
+Kentaro ptal, thanks.
4 years, 3 months ago (2016-09-12 22:09:35 UTC) #2
haraken
LGTM
4 years, 3 months ago (2016-09-13 01:23:10 UTC) #3
ssid
+primiano added few values in background_whitelist. ptal, thanks.
4 years, 3 months ago (2016-09-13 01:24:22 UTC) #5
hajimehoshi
lgtm
4 years, 3 months ago (2016-09-13 03:53:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337733002/20001
4 years, 3 months ago (2016-09-15 20:34:41 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 20:40:48 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/203b334b85d015fb651010ba89e6c6f31bae2b2e Cr-Commit-Position: refs/heads/master@{#418957}
4 years, 3 months ago (2016-09-15 20:42:32 UTC) #16
Primiano Tucci (use gerrit)
4 years, 2 months ago (2016-10-11 13:05:31 UTC) #17
Message was sent while issue was closed.
On 2016/09/15 20:42:32, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/203b334b85d015fb651010ba89e6c6f31bae2b2e
> Cr-Commit-Position: refs/heads/master@{#418957}

I think this is causing some funky accounting issues in webcache. see
crbug.com/654715

Powered by Google App Engine
This is Rietveld 408576698