Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2337713002: DevTools: find and launch chrome in debug mode (Closed)

Created:
4 years, 3 months ago by chenwilliam
Modified:
4 years, 3 months ago
Reviewers:
paulirish, dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: find and launch chrome in debug mode Cross-platform node.js script to automatically find Chrome Canary (in Mac and Windows) and launch it with debug flags. I've updated README which explains the workflow for users. Workflow commands (from /devtools): * npm start - starts Chrome and development server * npm run chrome - starts Chrome browser * npm run server - starts development server BUG=629914 Committed: https://crrev.com/f32d6d1fb625c48f647273dd3db5e1c5bceb1c84 Cr-Commit-Position: refs/heads/master@{#418469}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix copyright year #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/package.json View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/readme.md View 1 chunk +20 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js View 1 1 chunk +114 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/package.json View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/hosted_mode/server.js View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/devtools/scripts/start_chrome_and_server.js View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
chenwilliam
PTAL. After this lands, I will update contributing docs + publish this as a standalone ...
4 years, 3 months ago (2016-09-12 21:42:26 UTC) #3
pfeldman
lgtm https://codereview.chromium.org/2337713002/diff/1/third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js File third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js (right): https://codereview.chromium.org/2337713002/diff/1/third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js#newcode1 third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js:1: // Copyright 2014 The Chromium Authors. All rights ...
4 years, 3 months ago (2016-09-14 00:18:48 UTC) #4
chenwilliam
https://codereview.chromium.org/2337713002/diff/1/third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js File third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js (right): https://codereview.chromium.org/2337713002/diff/1/third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js#newcode1 third_party/WebKit/Source/devtools/scripts/chrome_debug_launcher/launch_chrome.js:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
4 years, 3 months ago (2016-09-14 00:29:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337713002/10001
4 years, 3 months ago (2016-09-14 00:30:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:10001)
4 years, 3 months ago (2016-09-14 03:08:28 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 03:10:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f32d6d1fb625c48f647273dd3db5e1c5bceb1c84
Cr-Commit-Position: refs/heads/master@{#418469}

Powered by Google App Engine
This is Rietveld 408576698