chrome/browser/extensions/api/tabs/tabs_api.h - Issue 23377002: Clean up windows API implementations to use JSON compiler generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.h

Issue 23377002: Clean up windows API implementations to use JSON compiler generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/tabs/tabs_api.h

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.h b/chrome/browser/extensions/api/tabs/tabs_api.h

index 1313b718ff4a03786b4bb14d5cdc672994da74f0..162e24515b4a32d9a5cb4d56456054590cc30010 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.h

+++ b/chrome/browser/extensions/api/tabs/tabs_api.h

@@ -71,7 +71,7 @@ class WindowsCreateFunction : public SyncExtensionFunction {

// mode. If window creation leads the browser into an erroneous state,

// |is_error| is set to true (also, error_ member variable is assigned

// the proper error message).

- bool ShouldOpenIncognitoWindow(const base::DictionaryValue* args,

+ bool ShouldOpenIncognitoWindow(const api::windows::Create::Params* args,

std::vector<GURL>* urls,

bool* is_error);

DECLARE_EXTENSION_FUNCTION("windows.create", WINDOWS_CREATE)

« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs_api.cc » ('j') | chrome/browser/extensions/api/tabs/tabs_api.cc » ('J')