Clean up windows API implementations to use JSON compiler generated code

chrome/browser/extensions/api/tabs/tabs_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_API_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 47 matching lines @@
   DECLARE_EXTENSION_FUNCTION("windows.getLastFocused", WINDOWS_GETLASTFOCUSED)
 };
 class WindowsGetAllFunction : public SyncExtensionFunction {
   virtual ~WindowsGetAllFunction() {}
   virtual bool RunImpl() OVERRIDE;
   DECLARE_EXTENSION_FUNCTION("windows.getAll", WINDOWS_GETALL)
 };
 class WindowsCreateFunction : public SyncExtensionFunction {
   virtual ~WindowsCreateFunction() {}
   virtual bool RunImpl() OVERRIDE;
   // Returns whether the window should be created in incognito mode.

[not at google - send to devlin, 2013/08/22 15:12:11]

add comment line:

|create_data| are the options passed by the extension. It may be NULL.

[pals, 2013/08/23 11:29:40]

Done.

   // |urls| is the list of urls to open. If we are creating an incognito window,
   // the function will remove these urls which may not be opened in incognito
   // mode.  If window creation leads the browser into an erroneous state,
   // |is_error| is set to true (also, error_ member variable is assigned
   // the proper error message).
-  bool ShouldOpenIncognitoWindow(const base::DictionaryValue* args,
-                                 std::vector<GURL>* urls,
-                                 bool* is_error);
+  bool ShouldOpenIncognitoWindow(
+      const api::windows::Create::Params::CreateData* create_data,
+      std::vector<GURL>* urls,
+      bool* is_error);
   DECLARE_EXTENSION_FUNCTION("windows.create", WINDOWS_CREATE)
 };
 class WindowsUpdateFunction : public SyncExtensionFunction {
   virtual ~WindowsUpdateFunction() {}
   virtual bool RunImpl() OVERRIDE;
   DECLARE_EXTENSION_FUNCTION("windows.update", WINDOWS_UPDATE)
 };
 class WindowsRemoveFunction : public SyncExtensionFunction {
   virtual ~WindowsRemoveFunction() {}
   virtual bool RunImpl() OVERRIDE;
@@ skipping 180 matching lines @@
   virtual ~TabsInsertCSSFunction() {}
 
   virtual bool ShouldInsertCSS() const OVERRIDE;
 
   DECLARE_EXTENSION_FUNCTION("tabs.insertCSS", TABS_INSERTCSS)
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_API_H_