Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 2337683002: Move String::truncate to StringImpl. (Closed)

Created:
4 years, 3 months ago by esprehn
Modified:
4 years, 3 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move String::truncate to StringImpl. String should be a thin wrapper over StringImpl and other functions. Committed: https://crrev.com/1f9dabc1afa3b43786cee46b548a428f463d7dc2 Cr-Commit-Position: refs/heads/master@{#419095}

Patch Set 1 #

Patch Set 2 : var names. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M third_party/WebKit/Source/wtf/text/StringImpl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.cpp View 1 2 1 chunk +3 lines, -14 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
esprehn
4 years, 3 months ago (2016-09-12 21:55:28 UTC) #7
haraken
LGTM
4 years, 3 months ago (2016-09-12 23:40:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337683002/20001
4 years, 3 months ago (2016-09-13 00:12:03 UTC) #11
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/wtf/text/WTFString.h: While running git apply --index -3 -p1; error: patch ...
4 years, 3 months ago (2016-09-13 00:43:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337683002/40001
4 years, 3 months ago (2016-09-16 00:25:27 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/298861)
4 years, 3 months ago (2016-09-16 02:14:24 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337683002/40001
4 years, 3 months ago (2016-09-16 02:25:16 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-16 03:44:36 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 03:46:22 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1f9dabc1afa3b43786cee46b548a428f463d7dc2
Cr-Commit-Position: refs/heads/master@{#419095}

Powered by Google App Engine
This is Rietveld 408576698