Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2337633002: Make command a HTMLUnknownElement (Closed)

Created:
4 years, 3 months ago by rwlbuis
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make command a HTMLUnknownElement Make command a HTMLUnknownElement [1]. Matches Firefox and Webkit. [1] https://html.spec.whatwg.org/multipage/dom.html#elements-in-the-dom:element-interface BUG=490511 TEST=imported/wpt/html/semantics/interfaces.html Committed: https://crrev.com/20a7ccc60205893eeaba7226fae870afc6db7c02 Cr-Commit-Position: refs/heads/master@{#418288}

Patch Set 1 #

Patch Set 2 : V2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/imported/wpt/html/semantics/interfaces-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTagNames.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
rwlbuis
PTAL.
4 years, 3 months ago (2016-09-13 14:10:09 UTC) #3
tkent
lgtm
4 years, 3 months ago (2016-09-13 16:23:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337633002/20001
4 years, 3 months ago (2016-09-13 16:23:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-13 17:45:10 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 17:47:50 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20a7ccc60205893eeaba7226fae870afc6db7c02
Cr-Commit-Position: refs/heads/master@{#418288}

Powered by Google App Engine
This is Rietveld 408576698