Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3887)

Unified Diff: chrome/browser/managed_mode/managed_user_service.cc

Issue 23376002: Move ManagedModePolicyProvider functionality to ManagedUserSettingsService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/managed_mode/managed_user_service.cc
diff --git a/chrome/browser/managed_mode/managed_user_service.cc b/chrome/browser/managed_mode/managed_user_service.cc
index 017aaac3acce09d7c76aaf2f9d2870b7d55976c6..96bb3a1d2f74659400d1839ad7e6933bf240e7f9 100644
--- a/chrome/browser/managed_mode/managed_user_service.cc
+++ b/chrome/browser/managed_mode/managed_user_service.cc
@@ -17,12 +17,12 @@
#include "chrome/browser/managed_mode/custodian_profile_downloader_service.h"
#include "chrome/browser/managed_mode/custodian_profile_downloader_service_factory.h"
#include "chrome/browser/managed_mode/managed_mode_site_list.h"
+#include "chrome/browser/managed_mode/managed_user_constants.h"
#include "chrome/browser/managed_mode/managed_user_registration_utility.h"
+#include "chrome/browser/managed_mode/managed_user_settings_service.h"
+#include "chrome/browser/managed_mode/managed_user_settings_service_factory.h"
#include "chrome/browser/managed_mode/managed_user_sync_service.h"
#include "chrome/browser/managed_mode/managed_user_sync_service_factory.h"
-#include "chrome/browser/policy/managed_mode_policy_provider.h"
-#include "chrome/browser/policy/profile_policy_connector.h"
-#include "chrome/browser/policy/profile_policy_connector_factory.h"
#include "chrome/browser/prefs/scoped_user_pref_update.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/signin/signin_manager.h"
@@ -48,7 +48,6 @@
#include "google_apis/gaia/google_service_auth_error.h"
#include "grit/generated_resources.h"
#include "net/base/escape.h"
-#include "policy/policy_constants.h"
#include "ui/base/l10n/l10n_util.h"
#if defined(OS_CHROMEOS)
@@ -58,7 +57,6 @@
using base::DictionaryValue;
using base::Value;
using content::BrowserThread;
-using policy::ManagedModePolicyProvider;
namespace {
@@ -449,10 +447,8 @@ ScopedVector<ManagedModeSiteList> ManagedUserService::GetActiveSiteLists() {
return site_lists.Pass();
}
-ManagedModePolicyProvider* ManagedUserService::GetPolicyProvider() {
- policy::ProfilePolicyConnector* connector =
- policy::ProfilePolicyConnectorFactory::GetForProfile(profile_);
- return connector->managed_mode_policy_provider();
+ManagedUserSettingsService* ManagedUserService::GetSettingsService() {
+ return ManagedUserSettingsServiceFactory::GetForProfile(profile_);
}
void ManagedUserService::OnDefaultFilteringBehaviorChanged() {
@@ -487,7 +483,7 @@ void ManagedUserService::AddAccessRequest(const GURL& url) {
std::string output(net::EscapeQueryParamValue(normalized_url.spec(), true));
// Add the prefix.
- std::string key = ManagedModePolicyProvider::MakeSplitSettingKey(
+ std::string key = ManagedUserSettingsService::MakeSplitSettingKey(
kManagedUserAccessRequestKeyPrefix, output);
scoped_ptr<DictionaryValue> dict(new DictionaryValue);
@@ -495,7 +491,7 @@ void ManagedUserService::AddAccessRequest(const GURL& url) {
// TODO(sergiu): Use sane time here when it's ready.
dict->SetDouble(kManagedUserAccessRequestTime, base::Time::Now().ToJsTime());
- GetPolicyProvider()->UploadItem(key, dict.PassAs<Value>());
+ GetSettingsService()->UploadItem(key, dict.PassAs<Value>());
}
ManagedUserService::ManualBehavior ManagedUserService::GetManualBehaviorForHost(
@@ -564,14 +560,15 @@ const char* ManagedUserService::GetManagedUserPseudoEmail() {
}
void ManagedUserService::Init() {
- ManagedModePolicyProvider* policy_provider = GetPolicyProvider();
+ ManagedUserSettingsService* settings_service = GetSettingsService();
+ DCHECK(settings_service->IsReady());
if (!ProfileIsManaged()) {
- if (policy_provider)
- policy_provider->Clear();
-
+ settings_service->Clear();
return;
}
+ settings_service->Activate();
+
CommandLine* command_line = CommandLine::ForCurrentProcess();
if (command_line->HasSwitch(switches::kManagedUserSyncToken)) {
InitSync(
@@ -609,9 +606,6 @@ void ManagedUserService::Init() {
BrowserList::AddObserver(this);
- if (policy_provider)
- policy_provider->InitLocalPolicies();
-
// Initialize the filter.
OnDefaultFilteringBehaviorChanged();
UpdateSiteLists();
@@ -720,7 +714,8 @@ void ManagedUserService::OnBrowserSetLastActive(Browser* browser) {
void ManagedUserService::RecordProfileAndBrowserEventsHelper(
const char* key_prefix) {
- std::string key = ManagedModePolicyProvider::MakeSplitSettingKey(key_prefix,
+ std::string key = ManagedUserSettingsService::MakeSplitSettingKey(
+ key_prefix,
base::Int64ToString(base::TimeTicks::Now().ToInternalValue()));
scoped_ptr<DictionaryValue> dict(new DictionaryValue);
@@ -728,8 +723,5 @@ void ManagedUserService::RecordProfileAndBrowserEventsHelper(
// TODO(bauerb): Use sane time when ready.
dict->SetDouble(kEventTimestamp, base::Time::Now().ToJsTime());
- ManagedModePolicyProvider* provider = GetPolicyProvider();
- // It is NULL in tests.
- if (provider)
- provider->UploadItem(key, dict.PassAs<Value>());
+ GetSettingsService()->UploadItem(key, dict.PassAs<Value>());
}

Powered by Google App Engine
This is Rietveld 408576698