Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2337583002: Make javascript field observe sdk document (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make javascript field observe sdk document Committed: https://pdfium.googlesource.com/pdfium/+/56cf519689846dd03a381fb6c4e7a054effdd20b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -50 lines) Patch
M fpdfsdk/javascript/Field.h View 2 chunks +3 lines, -1 line 2 comments Download
M fpdfsdk/javascript/Field.cpp View 39 chunks +62 lines, -49 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Tom Sepez
Dan, for review.
4 years, 3 months ago (2016-09-12 18:38:51 UTC) #4
Tom Sepez
https://codereview.chromium.org/2337583002/diff/1/fpdfsdk/javascript/Field.h File fpdfsdk/javascript/Field.h (right): https://codereview.chromium.org/2337583002/diff/1/fpdfsdk/javascript/Field.h#newcode14 fpdfsdk/javascript/Field.h:14: #include "fpdfsdk/include/fsdk_mgr.h" note: Dan, if you want to split ...
4 years, 3 months ago (2016-09-12 18:39:37 UTC) #5
dsinclair
lgtm https://codereview.chromium.org/2337583002/diff/1/fpdfsdk/javascript/Field.h File fpdfsdk/javascript/Field.h (right): https://codereview.chromium.org/2337583002/diff/1/fpdfsdk/javascript/Field.h#newcode14 fpdfsdk/javascript/Field.h:14: #include "fpdfsdk/include/fsdk_mgr.h" On 2016/09/12 18:39:37, Tom Sepez wrote: ...
4 years, 3 months ago (2016-09-12 18:49:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337583002/1
4 years, 3 months ago (2016-09-12 18:50:25 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 18:59:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/56cf519689846dd03a381fb6c4e7a054effd...

Powered by Google App Engine
This is Rietveld 408576698