Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(417)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-and-intrinsic-sizes-expected.txt
Issue
2337573003
:
[css-grid] Fix intrinsic size computation with flexible sized tracks (Closed)
Patch Set: Patch for landing
Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-and-intrinsic-sizes.html
third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-and-intrinsic-sizes-expected.txt
third_party/WebKit/Source/core/layout/LayoutGrid.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-and-intrinsic-sizes.html
('k') |
third_party/WebKit/Source/core/layout/LayoutGrid.cpp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 This test checks that fr tracks are properly sized whenever grid have intrinsic sizes.
1 This test checks that fr tracks are properly sized whenever grid have intrinsic sizes.
2
2
3 XXX XXX
3 XXX XXX
4 PASS
4 PASS
5 XXX XXX
5 XXX XXX
6
FAIL:
7
Expected 30 for width, but got 70.
8
9
<div class="container">
10
<div class="grid min-content" data-expected-width="30" data-expected-height="1 0">
11
<div>XXX XXX</div>
12
</div>
13
</div>
14
XXX XXX
15
PASS
16
XXX XXX
17 PASS
6 PASS
18 XXX XXX
7 XXX XXX
19 PASS
8 PASS
9
XXX XXX
10
PASS
11
XXX XXX
12
PASS
13
XXX XXXX XX X XX XXX
14
PASS
15
XXX XXXX XX X XX XXX
16
PASS
17
XXXX
18
XXXX XX XX
19
XXX XX X
20
XXXX XXX XXXX XXX XXXX
21
PASS
OLD
NEW
« no previous file with comments
|
« third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-and-intrinsic-sizes.html
('k') |
third_party/WebKit/Source/core/layout/LayoutGrid.cpp »
('j') |
no next file with comments »
Issue 2337573003: [css-grid] Fix intrinsic size computation with flexible sized tracks (Closed)
Created 4 years, 3 months ago by svillar
Modified 4 years, 3 months ago
Reviewers: Manuel Rego, jfernandez, eae, cbiesinger
Base URL:
Comments: 0
This is Rietveld
408576698