Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: chrome/browser/resources/history/other_devices.js

Issue 2337513002: Only handle click actions for left & middle buttons (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/history/other_devices.js
diff --git a/chrome/browser/resources/history/other_devices.js b/chrome/browser/resources/history/other_devices.js
index c4c04a5f7790fe91cdfe57dea157c8d7841cbb98..c031885c4098e240e5348a802ab21aea7b4ee0a5 100644
--- a/chrome/browser/resources/history/other_devices.js
+++ b/chrome/browser/resources/history/other_devices.js
@@ -286,6 +286,8 @@ Device.prototype.createSessionContents_ = function(maxNumTabs) {
// turns.
function makeClickHandler(sessionTag, windowId, tabId) {
return function(e) {
+ if (e.button !== 0 && e.button !== 1)
+ return; // Ignore buttons other than left and middle.
Dan Beam 2016/09/12 19:18:59 changing this code is fine, i suppose, but this wi
Navid Zolghadr 2016/09/12 19:50:09 To be honest with you the reported bug wasn't abou
recordUmaEvent_(HISTOGRAM_EVENT.LINK_CLICKED);
chrome.send('openForeignSession', [sessionTag, windowId, tabId,
e.button, e.altKey, e.ctrlKey, e.metaKey, e.shiftKey]);
« no previous file with comments | « no previous file | chrome/browser/resources/md_downloads/crisper.js » ('j') | chrome/browser/resources/md_downloads/crisper.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698