Only handle click actions for left & middle buttons

Only handle click actions for left & middle buttons

Change chrome pages to handle actions for left
and middle button click only.

BUG=645865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c2f7d5c86864715dc770bbc295a68c6ee7297f38
Cr-Commit-Position: refs/heads/master@{#420011}

[Navid Zolghadr, 2016-09-12 15:27:35]

Description was changed from

==========
Only handle click actions for left & middle buttons

Change chrome pages to handle actions for left
and middle button click only.

BUG=645865
==========

to

==========
Only handle click actions for left & middle buttons

Change chrome pages to handle actions for left
and middle button click only.

BUG=645865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Navid Zolghadr, 2016-09-12 15:27:42]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 15:27:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-09-12 15:29:59]

nzolghadr@chromium.org changed reviewers:
+ dbeam@chromium.org, dtapuska@chromium.org

[dtapuska, 2016-09-12 15:32:13]

On 2016/09/12 15:30:00, Navid Zolghadr wrote:

lgtm

[commit-bot: I haz the power, 2016-09-12 16:36:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 16:36:04]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-09-12 19:18:59]

https://codereview.chromium.org/2337513002/diff/1/chrome/browser/resources/hi...
File chrome/browser/resources/history/other_devices.js (right):

https://codereview.chromium.org/2337513002/diff/1/chrome/browser/resources/hi...
chrome/browser/resources/history/other_devices.js:290: return; // Ignore buttons
other than left and middle.
changing this code is fine, i suppose, but this will get axed reallly soon now

https://codereview.chromium.org/2337513002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/crisper.js (right):

https://codereview.chromium.org/2337513002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/crisper.js:652: return; // Ignore buttons
other than left and middle.
this is a generated file

you need to update ui/webui/resources/js/util.js and re-run

chrome/browser/resources/vulcanize.py

[Navid Zolghadr, 2016-09-12 19:50:09]

https://codereview.chromium.org/2337513002/diff/1/chrome/browser/resources/hi...
File chrome/browser/resources/history/other_devices.js (right):

https://codereview.chromium.org/2337513002/diff/1/chrome/browser/resources/hi...
chrome/browser/resources/history/other_devices.js:290: return; // Ignore buttons
other than left and middle.
On 2016/09/12 19:18:59, Dan Beam wrote:
> changing this code is fine, i suppose, but this will get axed reallly soon now

To be honest with you the reported bug wasn't about this. I just went over all
the changes I made in the original change and made sure I covered this case. If
this whole code gets removed that is okay.

https://codereview.chromium.org/2337513002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/crisper.js (right):

https://codereview.chromium.org/2337513002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/crisper.js:652: return; // Ignore buttons
other than left and middle.
On 2016/09/12 19:18:59, Dan Beam wrote:
> this is a generated file
> 
> you need to update ui/webui/resources/js/util.js and re-run
> 
> chrome/browser/resources/vulcanize.py

Umm. That is weird. Because I changed this file in the original review and
nobody complained. Was that also incorrect?
https://codereview.chromium.org/2163893003/

I tried modifying utils.js and running vulcanize.py. I got this error running it
from chrome/browser/resources. The error exists event with the tip of the tree
without my changes. Is this error familiar?

TypeError: exceptions must be old-style classes or derived from BaseException,
not NoneType

[Dan Beam, 2016-09-12 21:25:32]

https://codereview.chromium.org/2337513002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_downloads/crisper.js (right):

https://codereview.chromium.org/2337513002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_downloads/crisper.js:652: return; // Ignore buttons
other than left and middle.
On 2016/09/12 19:50:09, Navid Zolghadr wrote:
> On 2016/09/12 19:18:59, Dan Beam wrote:
> > this is a generated file
> > 
> > you need to update ui/webui/resources/js/util.js and re-run
> > 
> > chrome/browser/resources/vulcanize.py
> 
> Umm. That is weird. Because I changed this file in the original review and
> nobody complained. Was that also incorrect?
> https://codereview.chromium.org/2163893003/
> 
> I tried modifying utils.js and running vulcanize.py. I got this error running
it
> from chrome/browser/resources. The error exists event with the tip of the tree
> without my changes. Is this error familiar?
> 
> TypeError: exceptions must be old-style classes or derived from BaseException,
> not NoneType

you changed both util.js and crisper.js in similar ways

that part of the exception is not useful, but i'm almost sure you need to
install dependencies

[Navid Zolghadr, 2016-09-13 14:01:54]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 14:02:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 15:17:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 15:17:04]

Dry run: This issue passed the CQ dry run.

[Navid Zolghadr, 2016-09-13 16:53:01]

ptal.
I updated util.js as well. But I do seem to be having problem with running
vulcanize. I tried installing dependencies as well but I got a whole bunch of
error and digged in them for a few hours and hitting more errors. At that point
I thought maybe it might be okay to push this as is and later someone else who
has the environment setup just runs this or something like that similar to the
previous change?

[Navid Zolghadr, 2016-09-15 14:24:02]

On 2016/09/13 16:53:01, Navid Zolghadr wrote:
> ptal.
> I updated util.js as well. But I do seem to be having problem with running
> vulcanize. I tried installing dependencies as well but I got a whole bunch of
> error and digged in them for a few hours and hitting more errors. At that
point
> I thought maybe it might be okay to push this as is and later someone else who
> has the environment setup just runs this or something like that similar to the
> previous change?

Does this look okay as is?

[Dan Beam, 2016-09-16 01:16:12]

did you follow this?

https://chromium.googlesource.com/chromium/src/+/master/docs/vulcanize.md

[Dan Beam, 2016-09-16 01:17:27]

why not .button > 1?

[Navid Zolghadr, 2016-09-16 18:21:03]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 18:21:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-09-16 18:26:44]

On 2016/09/16 01:17:27, Dan Beam wrote:
> why not .button > 1?

I wanted to be explicit about the two buttons we are ignore. But this should be
fine too. So I changed it to use button > 1.

Regarding the instructions I did follow that. But I was getting this error
somewhere in the command that I was installing those 4 components.

npm ERR! TypeError: Cannot read property 'latest' of undefined
npm ERR!     at next (/usr/share/npm/lib/cache.js:687:35)
npm ERR!     at /usr/share/npm/lib/cache.js:675:5
npm ERR!     at saved
(/usr/share/npm/node_modules/npm-registry-client/lib/get.js:142:7)
npm ERR!     at /usr/lib/nodejs/graceful-fs/polyfills.js:133:7
npm ERR!     at Object.oncomplete (fs.js:107:15)
npm ERR! If you need help, you may report this log at:
npm ERR!     <http://github.com/isaacs/npm/issues>
npm ERR! or email it to:
npm ERR!     <npm-@googlegroups.com>

then I searched this one and found a few solutions some of them I did and didn't
solve the problem. For some others I got some other errors. I tried updating the
versions and still no chance. After a few hours of digging and trying I gave up
on this. If that complication needs to be done before landing this patch could
you please apply the patch to your local branch and land it for me?

[commit-bot: I haz the power, 2016-09-16 19:26:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 19:26:12]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-09-16 19:32:41]

On 2016/09/16 18:26:44, Navid Zolghadr wrote:
> On 2016/09/16 01:17:27, Dan Beam wrote:
> > why not .button > 1?
> 
> I wanted to be explicit about the two buttons we are ignore. But this should
be
> fine too. So I changed it to use button > 1.
> 
> Regarding the instructions I did follow that. But I was getting this error
> somewhere in the command that I was installing those 4 components.
> 
> npm ERR! TypeError: Cannot read property 'latest' of undefined
> npm ERR!     at next (/usr/share/npm/lib/cache.js:687:35)
> npm ERR!     at /usr/share/npm/lib/cache.js:675:5
> npm ERR!     at saved
> (/usr/share/npm/node_modules/npm-registry-client/lib/get.js:142:7)
> npm ERR!     at /usr/lib/nodejs/graceful-fs/polyfills.js:133:7
> npm ERR!     at Object.oncomplete (fs.js:107:15)
> npm ERR! If you need help, you may report this log at:
> npm ERR!     <http://github.com/isaacs/npm/issues>
> npm ERR! or email it to:
> npm ERR!     <mailto:npm-@googlegroups.com>
> 
> then I searched this one and found a few solutions some of them I did and
didn't
> solve the problem. For some others I got some other errors. I tried updating
the
> versions and still no chance. After a few hours of digging and trying I gave
up
> on this. If that complication needs to be done before landing this patch could
> you please apply the patch to your local branch and land it for me?

those are the wrong directories.  you either need to use `sudo npm install` if
you don't want to change your prefix, or set the npm install dir via

$ npm config set -g prefix "$HOME/node_modules"

like the guide says

[Navid Zolghadr, 2016-09-19 17:56:21]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 17:56:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2016-09-19 18:20:52]

ptal.
It also added another function in there as well. I guess someone else also
forgot to vulcanize or something.

[commit-bot: I haz the power, 2016-09-19 20:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:27:48]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-09-21 02:12:23]

On 2016/09/19 18:20:52, Navid Zolghadr wrote:
> ptal.
> It also added another function in there as well. I guess someone else also
> forgot to vulcanize or something.

yes, that happens every so often.  vulcanize (as a process) is still being
improved in chrome.  our goal is to eventually treat it more like build
artifacts than source code (i.e. use GN+ninja to create something in out/ based
on the mtime of all the files and NOT check it in :D).

lgtm

[Navid Zolghadr, 2016-09-21 07:50:58]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2016-09-21 07:50:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org
Link to the patchset: https://codereview.chromium.org/2337513002/#ps60001
(title: "vulanize the resources")

[commit-bot: I haz the power, 2016-09-21 07:51:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 09:06:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-21 09:09:00]

Description was changed from

==========
Only handle click actions for left & middle buttons

Change chrome pages to handle actions for left
and middle button click only.

BUG=645865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Only handle click actions for left & middle buttons

Change chrome pages to handle actions for left
and middle button click only.

BUG=645865
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c2f7d5c86864715dc770bbc295a68c6ee7297f38
Cr-Commit-Position: refs/heads/master@{#420011}
==========

[commit-bot: I haz the power, 2016-09-21 09:09:03]

Patchset 4 (id:??) landed as
https://crrev.com/c2f7d5c86864715dc770bbc295a68c6ee7297f38
Cr-Commit-Position: refs/heads/master@{#420011}