Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2337483002: Check for null return from GetNativeView(). (Closed)

Created:
4 years, 3 months ago by wjmaclean
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Check for null return from GetNativeView(). At present many (all?) consumers of RenderWidgetHostViewBase::GetNativeView() assume it always returns non- null, but this may not be a safe assumption if the view is a RenderWidgetHostViewChildFrame. This CL temporarily fixes a crash when ChromeOS hits this case, while we review the behaviour of the consumers of this function, and while we review the implementation in RenderWidgetHostViewChildFrame. BUG=644294, 644726 Review-Url: https://codereview.chromium.org/2322513002 Cr-Commit-Position: refs/heads/master@{#417288} (cherry picked from commit 079861f265916d3b9d6323a2f4cf07cdba864a05) Committed: https://chromium.googlesource.com/chromium/src/+/fd1a8a3acc82119847fd1ae38b50c84d34400c0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ui/keyboard/content/keyboard_ui_content.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wjmaclean
4 years, 3 months ago (2016-09-12 14:23:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fd1a8a3acc82119847fd1ae38b50c84d34400c0d.

Powered by Google App Engine
This is Rietveld 408576698