Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 233743002: Revert 263058 "Make isolate_driver.py process build.ninja and ex..." (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 263058 "Make isolate_driver.py process build.ninja and ex..." Seems to have busted Mac builds, e.g., http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20Builder%20%28dbg%29&number=65094: FAILED: cd ../../net; export BUILT_PRODUCTS_DIR=/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/out/Debug; export CONFIGURATION=Debug; export PRODUCT_NAME=net_unittests_run; export SDKROOT=/Developer/SDKs/MacOSX10.6.sdk; export SRCROOT=/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/out/Debug/../../net; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/out/Debug; export TEMP_DIR="${TMPDIR}";python ../tools/isolate_driver.py check --isolated "../out/Debug/net_unittests.isolated" --isolate "net_unittests.isolate" --path-variable PRODUCT_DIR "../out/Debug " --extra-variable "version_full=36.0.1935.0" --config-variable "OS=mac" --config-variable "chromeos=0" --config-variable "component=shared_library" --config-variable "internal_gles2_conform_tests=0" --config-variable "icu_use_data_file_flag=1" --config-variable "libpeer_target_type=static_library" --config-variable "use_openssl=0" --extra-variable mac_product_name Chromium --ignore_broken_items [------ Swarming Error ------] File /Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/out/Debug/net_resources_target_net_resources_d558be7de16a8d003a6e7f7fae73e582 doesn't exist Traceback (most recent call last): File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolate.py", line 1516, in main return dispatcher.execute(OptionParserIsolate(version=__version__), argv) File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/third_party/depot_tools/subcommand.py", line 242, in execute return command(parser, args[1:]) File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolate.py", line 1082, in CMDcheck options, os.getcwd(), options.subdir, False) File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolate.py", line 888, in load_complete_state options.extra_variables, options.ignore_broken_items) File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolate.py", line 762, in load_isolate ignore_broken_items) File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolate.py", line 63, in expand_directories_and_symlinks indir, relfile, blacklist, follow_symlinks)) File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolateserver.py", line 1450, in expand_directory_and_symlink relfile, symlinks = expand_symlinks(indir, relfile) File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/isolateserver.py", line 1358, in expand_symlinks todo = file_path.fix_native_path_case(done, todo) File "/Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/swarming_client/utils/file_path.py", line 488, in fix_native_path_case os.path.join(native_case_path, raw_part)) OSError: File /Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/out/Debug/net_resources_target_net_resources_d558be7de16a8d003a6e7f7fae73e582 doesn't exist [----------------------------] > Make isolate_driver.py process build.ninja and extract dependencies. > > This uses a few assumption: > - This basically breaks non-ninja build for component builds. This never worked > anyway. > - This assumes the file format of .ninja files. This will likely be quite > obvious when this breaks. > - It makes some assumptions about the build steps, for example '.so.TOC' -> > '.so'. > > On the other hand, it creates a deterministic dependency tree, which is awesome. > Technically it would work as well for non-component builds but I don't want to > go this far yet. But in the end, that's the goal that nobody has to enter the > binary dependencies in the .isolate files. > > R=csharp@chromium.org > BUG=360223, 333473 > > Review URL: https://codereview.chromium.org/228463003 TBR=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263072

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -160 lines) Patch
M trunk/src/tools/isolate_driver.py View 5 chunks +58 lines, -160 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
6 years, 8 months ago (2014-04-10 20:37:42 UTC) #1
viettrungluu
6 years, 8 months ago (2014-04-10 20:38:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r263072.

Powered by Google App Engine
This is Rietveld 408576698