Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2337393002: Compile fix for merge of codereview.chromium.org/2299203004 (Closed)

Created:
4 years, 3 months ago by asargent_no_longer_on_chrome
Modified:
4 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Compile fix for merge of codereview.chromium.org/2299203004 Some code the test was written against had changed a method signature since the 2840 branch was cut. TBR=lazyboy@chromium.org BUG=646663

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/extensions/content_verifier_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
asargent_no_longer_on_chrome
4 years, 3 months ago (2016-09-14 04:10:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337393002/1
4 years, 3 months ago (2016-09-14 04:11:17 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 3 months ago (2016-09-14 04:11:20 UTC) #7
asargent_no_longer_on_chrome
4 years, 3 months ago (2016-09-14 04:20:35 UTC) #9
I started committing this via 'git cl land' and while that was working realized
I had put the wrong bug number in the description. I've updated the description
here to correctly point to bug 646663 but the bug entry might not get the
automatic notice appended to it by the commit process.

Powered by Google App Engine
This is Rietveld 408576698