Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: ash/common/wm/overview/window_selector_item.h

Issue 2337383003: [ash-md] Corrects a crash when a window is destroyed after leaving overview (Closed)
Patch Set: [ash-md] Corrects a crash when a window is destroyed after leaving overview (nits) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ash/common/wm/overview/window_selector_item.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ASH_COMMON_WM_OVERVIEW_WINDOW_SELECTOR_ITEM_H_ 5 #ifndef ASH_COMMON_WM_OVERVIEW_WINDOW_SELECTOR_ITEM_H_
6 #define ASH_COMMON_WM_OVERVIEW_WINDOW_SELECTOR_ITEM_H_ 6 #define ASH_COMMON_WM_OVERVIEW_WINDOW_SELECTOR_ITEM_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "ash/ash_export.h" 10 #include "ash/ash_export.h"
11 #include "ash/common/wm/overview/scoped_transform_overview_window.h" 11 #include "ash/common/wm/overview/scoped_transform_overview_window.h"
12 #include "ash/common/wm_window_observer.h" 12 #include "ash/common/wm_window_observer.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "ui/gfx/geometry/insets.h" 14 #include "ui/gfx/geometry/insets.h"
15 #include "ui/gfx/geometry/rect.h" 15 #include "ui/gfx/geometry/rect.h"
16 #include "ui/views/controls/button/button.h" 16 #include "ui/views/controls/button/button.h"
17 #include "ui/views/controls/button/image_button.h" 17 #include "ui/views/controls/button/image_button.h"
18 #include "ui/views/controls/button/label_button.h" 18 #include "ui/views/controls/button/label_button.h"
19 #include "ui/views/widget/widget.h" 19 #include "ui/views/widget/widget.h"
20 20
21 namespace gfx {
22 class SlideAnimation;
23 }
24
21 namespace views { 25 namespace views {
22 class ImageButton; 26 class ImageButton;
23 } 27 }
24 28
25 namespace wm { 29 namespace wm {
26 class Shadow; 30 class Shadow;
27 } 31 }
28 32
29 namespace ash { 33 namespace ash {
30 34
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 // Animates opacity of the |transform_window_| and its caption to |opacity| 198 // Animates opacity of the |transform_window_| and its caption to |opacity|
195 // using |animation_type|. 199 // using |animation_type|.
196 void AnimateOpacity(float opacity, OverviewAnimationType animation_type); 200 void AnimateOpacity(float opacity, OverviewAnimationType animation_type);
197 201
198 // Updates the close buttons accessibility name. 202 // Updates the close buttons accessibility name.
199 void UpdateCloseButtonAccessibilityName(); 203 void UpdateCloseButtonAccessibilityName();
200 204
201 // Fades out a window caption when exiting overview mode. 205 // Fades out a window caption when exiting overview mode.
202 void FadeOut(std::unique_ptr<views::Widget> widget); 206 void FadeOut(std::unique_ptr<views::Widget> widget);
203 207
208 // Allows a test to directly set animation state.
209 gfx::SlideAnimation* GetBackgroundViewAnimation();
210
204 static bool hide_header() { return use_mask_ || use_shape_; } 211 static bool hide_header() { return use_mask_ || use_shape_; }
205 212
206 // True if the item is being shown in the overview, false if it's being 213 // True if the item is being shown in the overview, false if it's being
207 // filtered. 214 // filtered.
208 bool dimmed_; 215 bool dimmed_;
209 216
210 // The root window this item is being displayed on. 217 // The root window this item is being displayed on.
211 WmWindow* root_window_; 218 WmWindow* root_window_;
212 219
213 // The contained Window's wrapper. 220 // The contained Window's wrapper.
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 // shape. This has performance implications so it can be disabled when there 273 // shape. This has performance implications so it can be disabled when there
267 // are many windows. 274 // are many windows.
268 static bool use_shape_; 275 static bool use_shape_;
269 276
270 DISALLOW_COPY_AND_ASSIGN(WindowSelectorItem); 277 DISALLOW_COPY_AND_ASSIGN(WindowSelectorItem);
271 }; 278 };
272 279
273 } // namespace ash 280 } // namespace ash
274 281
275 #endif // ASH_COMMON_WM_OVERVIEW_WINDOW_SELECTOR_ITEM_H_ 282 #endif // ASH_COMMON_WM_OVERVIEW_WINDOW_SELECTOR_ITEM_H_
OLDNEW
« no previous file with comments | « no previous file | ash/common/wm/overview/window_selector_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698