Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2337383002: Fix swarming for content_browsertests and browser_tests on site isolation bots. (Closed)

Created:
4 years, 3 months ago by jam
Modified:
4 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix swarming for content_browsertests and browser_tests on site isolation bots. The problem was that the path to the filter is different depending on whether the test is swarmed or not. Also make sure to send the filter file for the tests as part of the isolate data. BUG=645983 TBR=scottmg@chromium.org Committed: https://crrev.com/bea11049a26e85a52b866380f93080f878ccd96c Cr-Commit-Position: refs/heads/master@{#418485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M chrome/test/BUILD.gn View 2 chunks +5 lines, -4 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
4 years, 3 months ago (2016-09-14 03:14:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337383002/1
4 years, 3 months ago (2016-09-14 03:15:07 UTC) #3
scottmg
lgtm
4 years, 3 months ago (2016-09-14 04:22:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 04:26:35 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 04:28:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bea11049a26e85a52b866380f93080f878ccd96c
Cr-Commit-Position: refs/heads/master@{#418485}

Powered by Google App Engine
This is Rietveld 408576698