Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4198)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2337363002: Load live version when reloading an offline page on connected network (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index f97f467908e0ad2af404f8aed63c22a52cd2777b..31517c90511b695f232bd47671f8a94096347fe8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -1016,6 +1016,11 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
if (getBlimpContents() != null) {
getBlimpContents().getNavigationController().reload();
}
+ } else if (isOfflinePage()) {
+ LoadUrlParams params =
+ new LoadUrlParams(getOriginalUrl(), PageTransition.RELOAD);
+ params.setVerbatimHeaders(nativeGetOfflinePageHeaderForReload(mNativeTabAndroid));
+ loadUrl(params);
} else {
if (getWebContents() != null) getWebContents().getNavigationController().reload(true);
}
@@ -3334,6 +3339,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
private native long nativeGetBookmarkId(long nativeTabAndroid, boolean onlyEditable);
private native boolean nativeIsOfflinePage(long nativeTabAndroid);
private native OfflinePageItem nativeGetOfflinePage(long nativeTabAndroid);
+ private native String nativeGetOfflinePageHeaderForReload(long nativeTabAndroid);
private native void nativeSetInterceptNavigationDelegate(long nativeTabAndroid,
InterceptNavigationDelegate delegate);
private native void nativeAttachToTabContentManager(long nativeTabAndroid,

Powered by Google App Engine
This is Rietveld 408576698