Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1454)

Unified Diff: content/child/webcrypto/webcrypto_impl.h

Issue 233733004: [webcrypto] Make operations run on worker threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix argument ordering bug Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/webcrypto/webcrypto_impl.h
diff --git a/content/child/webcrypto/webcrypto_impl.h b/content/child/webcrypto/webcrypto_impl.h
index f28cdb1a479336573f36910c92eabad64a6f3e76..179de041cb5c7a1f0963ec0fb9b34a9d385674c4 100644
--- a/content/child/webcrypto/webcrypto_impl.h
+++ b/content/child/webcrypto/webcrypto_impl.h
@@ -13,7 +13,7 @@
namespace content {
-// Wrapper around the blink WebCrypto asynchronous interface, which forwards to
+// Wrapper around the Blink WebCrypto asynchronous interface, which forwards to
// the synchronous platfrom (NSS or OpenSSL) implementation.
//
// TODO(eroman): Post the synchronous work to a background thread.
@@ -77,12 +77,7 @@ class WebCryptoImpl : public blink::WebCrypto {
bool extractable,
blink::WebCryptoKeyUsageMask usages,
blink::WebCryptoResult result);
- // This method synchronously computes a digest for the given data, returning
- // |true| if successful and |false| otherwise.
- virtual bool digestSynchronous(const blink::WebCryptoAlgorithmId algorithm_id,
- const unsigned char* data,
- unsigned int data_size,
- blink::WebArrayBuffer& result);
+
// This method returns a digestor object that can be used to synchronously
// compute a digest one chunk at a time. Thus, the consume does not need to
// hold onto a large buffer with all the data to digest. Chunks can be given

Powered by Google App Engine
This is Rietveld 408576698