Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 233733002: Add ui/wm to aura_builder target (Closed)

Created:
6 years, 8 months ago by oshima
Modified:
6 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews
Visibility:
Public.

Description

Add ui/wm to aura_builder target This is to mitigate the issue crbug.com/354775 by at least compiling wm_core_unittsts on bots. BUG=354775 R=jamescook@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263083

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
6 years, 8 months ago (2014-04-10 20:05:04 UTC) #1
James Cook
What is aura_builder used for? Why do you need to make this change? (I may ...
6 years, 8 months ago (2014-04-10 20:26:16 UTC) #2
oshima
On 2014/04/10 20:26:16, James Cook wrote: > What is aura_builder used for? Why do you ...
6 years, 8 months ago (2014-04-10 20:37:37 UTC) #3
James Cook
So the idea is to force ui/wm to compile on chromeos, even if the tests ...
6 years, 8 months ago (2014-04-10 20:48:52 UTC) #4
oshima
6 years, 8 months ago (2014-04-10 21:13:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r263083 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698