src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp - Issue 2337313002: (Some) gradients are gamma and gamut correct on GPU

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp

Issue 2337313002: (Some) gradients are gamma and gamut correct on GPU (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp

diff --git a/src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp b/src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp

index a5813215467d3eca8905762d78d8d07871c510c9..2e4c217990db1ba39dab504191976f57d5fffeb7 100644

--- a/src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp

+++ b/src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp

@@ -1305,7 +1305,8 @@ sk_sp<GrFragmentProcessor> Gr2PtConicalGradientEffect::Make(

matrix.postConcat(inv);

}

- GrGradientEffect::CreateArgs newArgs(args.fContext, args.fShader, &matrix, args.fTileMode);

+ GrGradientEffect::CreateArgs newArgs(args.fContext, args.fShader, &matrix, args.fTileMode,

+ std::move(args.fColorSpaceXform), args.fGammaCorrect);

if (shader.getStartRadius() < kErrorTol) {

SkScalar focalX;