Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2337263002: Add recipe-roller as an OWNER of recipe modules. (Closed)

Created:
4 years, 3 months ago by martiniss
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add recipe-roller as an OWNER of recipe modules. See https://codereview.chromium.org/2335163004 for why this is needed. The roller can't land a non-trivial CL with the upstream author's LGTM, because it's not an OWNER of the recipes in the repo it's rolling into. Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/33061f78a10a7e44537a4c0384c5dab68d61f1ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A recipe_modules/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
martiniss
PTAL
4 years, 3 months ago (2016-09-13 18:15:34 UTC) #2
Paweł Hajdan Jr.
LGTM Shouldn't we also add it to recipes though?
4 years, 3 months ago (2016-09-13 19:02:51 UTC) #3
iannucci
lgtm, and +1 to phajdan's comment
4 years, 3 months ago (2016-09-13 22:59:52 UTC) #4
martiniss
On 2016/09/13 at 19:02:51, phajdan.jr wrote: > LGTM > > Shouldn't we also add it ...
4 years, 3 months ago (2016-09-13 23:00:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337263002/1
4 years, 3 months ago (2016-09-14 00:29:34 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 00:32:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/33061f78a10a7e...

Powered by Google App Engine
This is Rietveld 408576698