Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerReportingProxy.h

Issue 2337253005: Worker: Canonicalize names of WorkerThread lifecycle events in WorkerReportingProxy (Closed)
Patch Set: fix comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerReportingProxy.h
diff --git a/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h b/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h
index 46895eb2fe0f0b1bcb85872b02063a5054ae5a76..806dca267487443bb921ae21ed1bfc7667a0530a 100644
--- a/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h
+++ b/third_party/WebKit/Source/core/workers/WorkerReportingProxy.h
@@ -55,28 +55,30 @@ public:
// Invoked when the worker script or imported script is loaded.
virtual void didLoadWorkerScript(size_t scriptSize, size_t cachedMetadataSize) { }
- // Invoked when the worker script is evaluated. |success| is true if the
- // evaluation completed with no uncaught exception.
- virtual void didEvaluateWorkerScript(bool success) = 0;
+ // Invoked when the new WorkerGlobalScope is created. This is called after
+ // didLoadWorkerScript().
+ virtual void didCreateWorkerGlobalScope(WorkerOrWorkletGlobalScope*) { }
- // Invoked when the thread creates a worker script context.
+ // Invoked when the WorkerGlobalScope is initialized. This is called after
+ // didCreateWorkerGlobalScope().
virtual void didInitializeWorkerContext() { }
- // Invoked when the new WorkerGlobalScope is started.
- virtual void workerGlobalScopeStarted(WorkerOrWorkletGlobalScope*) { }
+ // Invoked when the worker script is evaluated. |success| is true if the
+ // evaluation completed with no uncaught exception. This is called after
+ // didInitializeWorkerContext().
+ virtual void didEvaluateWorkerScript(bool success) = 0;
// Invoked when close() is invoked on the worker context.
- virtual void workerGlobalScopeClosed() = 0;
-
- // Invoked when the thread is stopped and WorkerGlobalScope is being
- // destructed. (This is be the last method that is called on this
- // interface)
- virtual void workerThreadTerminated() = 0;
+ virtual void didCloseWorkerGlobalScope() = 0;
// Invoked when the thread is about to be stopped and WorkerGlobalScope
- // is to be destructed. (When this is called it is guaranteed that
- // WorkerGlobalScope is still alive)
+ // is to be destructed. When this is called, it is guaranteed that
+ // WorkerGlobalScope is still alive.
virtual void willDestroyWorkerGlobalScope() = 0;
+
+ // Invoked when the thread is stopped and WorkerGlobalScope is being
+ // destructed. This is the last method that is called on this interface.
+ virtual void didTerminateWorkerThread() = 0;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698