third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h - Issue 2337253005: Worker: Canonicalize names of WorkerThread lifecycle events in WorkerReportingProxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

Issue 2337253005: Worker: Canonicalize names of WorkerThread lifecycle events in WorkerReportingProxy (Closed)

Patch Set: fix comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp ('k') | third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

diff --git a/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h b/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

index 3950307d99c09605870ce856fd23665eab0be891..b122f3dab424ff1b3844c6de52bf77f8e4a3ec07 100644

--- a/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

+++ b/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

@@ -74,11 +74,11 @@ public:

void reportException(const String& errorMessage, std::unique_ptr<SourceLocation>, int exceptionId) override;

void reportConsoleMessage(MessageSource, MessageLevel, const String& message, SourceLocation*) override;

void postMessageToPageInspector(const String&) override;

+ void didCreateWorkerGlobalScope(WorkerOrWorkletGlobalScope*) override;

void didEvaluateWorkerScript(bool success) override;

- void workerGlobalScopeStarted(WorkerOrWorkletGlobalScope*) override;

- void workerGlobalScopeClosed() override;

- void workerThreadTerminated() override;

+ void didCloseWorkerGlobalScope() override;

void willDestroyWorkerGlobalScope() override;

+ void didTerminateWorkerThread() override;

protected:

InProcessWorkerObjectProxy(InProcessWorkerMessagingProxy*);