net/websockets/websocket_basic_handshake_stream.cc - Issue 2337253004: Update Token Binding code to the latest drafts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/websockets/websocket_basic_handshake_stream.cc

Issue 2337253004: Update Token Binding code to the latest drafts (Closed)

Patch Set: Add call to CBS_len() Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/websockets/websocket_basic_handshake_stream.cc

diff --git a/net/websockets/websocket_basic_handshake_stream.cc b/net/websockets/websocket_basic_handshake_stream.cc

index ae6062ea96d0bf3e0a41bab17dab484494bbae7d..424033ba88db3e95725bc59b1d125d9ad8a580a4 100644

--- a/net/websockets/websocket_basic_handshake_stream.cc

+++ b/net/websockets/websocket_basic_handshake_stream.cc

@@ -447,8 +447,9 @@ void WebSocketBasicHandshakeStream::PopulateNetErrorDetails(

return;

}

-Error WebSocketBasicHandshakeStream::GetSignedEKMForTokenBinding(

+Error WebSocketBasicHandshakeStream::GetTokenBindingSignature(

crypto::ECPrivateKey* key,

+ TokenBindingType tb_type,

std::vector<uint8_t>* out) {

NOTREACHED();

return ERR_NOT_IMPLEMENTED;