Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 2337253004: Update Token Binding code to the latest drafts (Closed)
Patch Set: Add call to CBS_len() Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_job.cc ('k') | net/websockets/websocket_basic_handshake_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index f2203e0f99ca297d62d6a46cce21f47ac54b7916..fece0535e440c5cfb195723c2d0f4aaaefeac5d2 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -3421,7 +3421,7 @@ TEST_F(TokenBindingURLRequestTest, TokenBindingTest) {
EXPECT_TRUE(headers.GetHeader(HttpRequestHeaders::kTokenBinding,
&token_binding_header));
EXPECT_TRUE(base::Base64UrlDecode(
- token_binding_header, base::Base64UrlDecodePolicy::REQUIRE_PADDING,
+ token_binding_header, base::Base64UrlDecodePolicy::DISALLOW_PADDING,
&token_binding_message));
std::vector<TokenBinding> token_bindings;
ASSERT_TRUE(
@@ -3432,8 +3432,9 @@ TEST_F(TokenBindingURLRequestTest, TokenBindingTest) {
std::string ekm = d.data_received();
EXPECT_EQ(TokenBindingType::PROVIDED, token_bindings[0].type);
- EXPECT_TRUE(VerifyEKMSignature(token_bindings[0].ec_point,
- token_bindings[0].signature, ekm));
+ EXPECT_TRUE(VerifyTokenBindingSignature(token_bindings[0].ec_point,
+ token_bindings[0].signature,
+ TokenBindingType::PROVIDED, ekm));
}
}
@@ -3464,7 +3465,7 @@ TEST_F(TokenBindingURLRequestTest, ForwardTokenBinding) {
EXPECT_TRUE(headers.GetHeader(HttpRequestHeaders::kTokenBinding,
&token_binding_header));
EXPECT_TRUE(base::Base64UrlDecode(
- token_binding_header, base::Base64UrlDecodePolicy::REQUIRE_PADDING,
+ token_binding_header, base::Base64UrlDecodePolicy::DISALLOW_PADDING,
&token_binding_message));
std::vector<TokenBinding> token_bindings;
ASSERT_TRUE(
@@ -3475,11 +3476,13 @@ TEST_F(TokenBindingURLRequestTest, ForwardTokenBinding) {
std::string ekm = d.data_received();
EXPECT_EQ(TokenBindingType::PROVIDED, token_bindings[0].type);
- EXPECT_TRUE(VerifyEKMSignature(token_bindings[0].ec_point,
- token_bindings[0].signature, ekm));
+ EXPECT_TRUE(VerifyTokenBindingSignature(token_bindings[0].ec_point,
+ token_bindings[0].signature,
+ TokenBindingType::PROVIDED, ekm));
EXPECT_EQ(TokenBindingType::REFERRED, token_bindings[1].type);
- EXPECT_TRUE(VerifyEKMSignature(token_bindings[1].ec_point,
- token_bindings[1].signature, ekm));
+ EXPECT_TRUE(VerifyTokenBindingSignature(token_bindings[1].ec_point,
+ token_bindings[1].signature,
+ TokenBindingType::REFERRED, ekm));
}
}
@@ -3517,7 +3520,7 @@ TEST_F(TokenBindingURLRequestTest, DontForwardHeaderFromHttp) {
EXPECT_TRUE(headers.GetHeader(HttpRequestHeaders::kTokenBinding,
&token_binding_header));
EXPECT_TRUE(base::Base64UrlDecode(
- token_binding_header, base::Base64UrlDecodePolicy::REQUIRE_PADDING,
+ token_binding_header, base::Base64UrlDecodePolicy::DISALLOW_PADDING,
&token_binding_message));
std::vector<TokenBinding> token_bindings;
ASSERT_TRUE(
@@ -3528,8 +3531,9 @@ TEST_F(TokenBindingURLRequestTest, DontForwardHeaderFromHttp) {
std::string ekm = d.data_received();
EXPECT_EQ(TokenBindingType::PROVIDED, token_bindings[0].type);
- EXPECT_TRUE(VerifyEKMSignature(token_bindings[0].ec_point,
- token_bindings[0].signature, ekm));
+ EXPECT_TRUE(VerifyTokenBindingSignature(token_bindings[0].ec_point,
+ token_bindings[0].signature,
+ TokenBindingType::PROVIDED, ekm));
}
}
« no previous file with comments | « net/url_request/url_request_job.cc ('k') | net/websockets/websocket_basic_handshake_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698