Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 2337253004: Update Token Binding code to the latest drafts (Closed)
Patch Set: Fix compilation error in unit_tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 057900a9c7b392bc2ae4c5f47f7051a813d7700a..c442d650f8bf8218b6f49150509c382e7bd193fb 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -3427,7 +3427,7 @@ TEST_F(TokenBindingURLRequestTest, TokenBindingTest) {
EXPECT_TRUE(headers.GetHeader(HttpRequestHeaders::kTokenBinding,
&token_binding_header));
EXPECT_TRUE(base::Base64UrlDecode(
- token_binding_header, base::Base64UrlDecodePolicy::REQUIRE_PADDING,
+ token_binding_header, base::Base64UrlDecodePolicy::DISALLOW_PADDING,
&token_binding_message));
std::vector<TokenBinding> token_bindings;
ASSERT_TRUE(
@@ -3438,8 +3438,9 @@ TEST_F(TokenBindingURLRequestTest, TokenBindingTest) {
std::string ekm = d.data_received();
EXPECT_EQ(TokenBindingType::PROVIDED, token_bindings[0].type);
- EXPECT_TRUE(VerifyEKMSignature(token_bindings[0].ec_point,
- token_bindings[0].signature, ekm));
+ EXPECT_TRUE(VerifyTokenBindingSignature(token_bindings[0].ec_point,
+ token_bindings[0].signature,
+ TokenBindingType::PROVIDED, ekm));
}
}
@@ -3470,7 +3471,7 @@ TEST_F(TokenBindingURLRequestTest, ForwardTokenBinding) {
EXPECT_TRUE(headers.GetHeader(HttpRequestHeaders::kTokenBinding,
&token_binding_header));
EXPECT_TRUE(base::Base64UrlDecode(
- token_binding_header, base::Base64UrlDecodePolicy::REQUIRE_PADDING,
+ token_binding_header, base::Base64UrlDecodePolicy::DISALLOW_PADDING,
&token_binding_message));
std::vector<TokenBinding> token_bindings;
ASSERT_TRUE(
@@ -3481,11 +3482,13 @@ TEST_F(TokenBindingURLRequestTest, ForwardTokenBinding) {
std::string ekm = d.data_received();
EXPECT_EQ(TokenBindingType::PROVIDED, token_bindings[0].type);
- EXPECT_TRUE(VerifyEKMSignature(token_bindings[0].ec_point,
- token_bindings[0].signature, ekm));
+ EXPECT_TRUE(VerifyTokenBindingSignature(token_bindings[0].ec_point,
+ token_bindings[0].signature,
+ TokenBindingType::PROVIDED, ekm));
EXPECT_EQ(TokenBindingType::REFERRED, token_bindings[1].type);
- EXPECT_TRUE(VerifyEKMSignature(token_bindings[1].ec_point,
- token_bindings[1].signature, ekm));
+ EXPECT_TRUE(VerifyTokenBindingSignature(token_bindings[1].ec_point,
+ token_bindings[1].signature,
+ TokenBindingType::REFERRED, ekm));
}
}
@@ -3523,7 +3526,7 @@ TEST_F(TokenBindingURLRequestTest, DontForwardHeaderFromHttp) {
EXPECT_TRUE(headers.GetHeader(HttpRequestHeaders::kTokenBinding,
&token_binding_header));
EXPECT_TRUE(base::Base64UrlDecode(
- token_binding_header, base::Base64UrlDecodePolicy::REQUIRE_PADDING,
+ token_binding_header, base::Base64UrlDecodePolicy::DISALLOW_PADDING,
&token_binding_message));
std::vector<TokenBinding> token_bindings;
ASSERT_TRUE(
@@ -3534,8 +3537,9 @@ TEST_F(TokenBindingURLRequestTest, DontForwardHeaderFromHttp) {
std::string ekm = d.data_received();
EXPECT_EQ(TokenBindingType::PROVIDED, token_bindings[0].type);
- EXPECT_TRUE(VerifyEKMSignature(token_bindings[0].ec_point,
- token_bindings[0].signature, ekm));
+ EXPECT_TRUE(VerifyTokenBindingSignature(token_bindings[0].ec_point,
+ token_bindings[0].signature,
+ TokenBindingType::PROVIDED, ekm));
}
}

Powered by Google App Engine
This is Rietveld 408576698