Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: ui/views/cocoa/bridged_content_view.mm

Issue 2337233004: MacViews: Fix sending mouse exit event and releasing capture on D&D. (Closed)
Patch Set: Fix review issues. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/cocoa/drag_drop_client_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/cocoa/bridged_content_view.mm
diff --git a/ui/views/cocoa/bridged_content_view.mm b/ui/views/cocoa/bridged_content_view.mm
index 1623e32b8ede82ff2b578ad5500010dca09f991c..d666d850d4d519959bb129c30f7f2c44a468c7c8 100644
--- a/ui/views/cocoa/bridged_content_view.mm
+++ b/ui/views/cocoa/bridged_content_view.mm
@@ -555,6 +555,12 @@ ui::KeyEvent GetCharacterEventFromNSEvent(NSEvent* event) {
hostedView_->GetWidget()->OnMouseEvent(&event);
}
+// http://crbug.com/646792
+// Disable pendingExitEvent_ logic in BaseView.
+- (void)mouseDown:(NSEvent*)theEvent {
snake 2016/09/22 18:22:39 What about this MacViews specific fix, for now?
tapted 2016/09/23 07:10:21 The code looks good, but I tried commenting this o
snake 2016/09/26 10:28:48 hm.. I will investigate this. I did remove this fo
+ [self mouseEvent:theEvent];
+}
+
// NSView implementation.
- (BOOL)acceptsFirstResponder {
« no previous file with comments | « no previous file | ui/views/cocoa/drag_drop_client_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698