Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: ui/views/cocoa/drag_drop_client_mac.mm

Issue 2337233004: MacViews: Fix sending mouse exit event and releasing capture on D&D. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/cocoa/drag_drop_client_mac.mm
diff --git a/ui/views/cocoa/drag_drop_client_mac.mm b/ui/views/cocoa/drag_drop_client_mac.mm
index f2b77998edb4a177aca2703b3d8690e4a464a4b8..5e75e4474ac81062eb8856e34e36eb18070d5b77 100644
--- a/ui/views/cocoa/drag_drop_client_mac.mm
+++ b/ui/views/cocoa/drag_drop_client_mac.mm
@@ -79,6 +79,8 @@ void DragDropClientMac::StartDragAndDrop(
const ui::OSExchangeDataProviderMac& provider =
static_cast<const ui::OSExchangeDataProviderMac&>(data.provider());
+ bridge_->ReleaseCapture();
tapted 2016/09/19 00:31:01 Can you explain this change? Does it correspond to
snake 2016/09/20 15:04:26 Yes.
tapted 2016/09/21 10:07:05 OK, if we don't fix it a different way, we'll need
snake 2016/09/21 12:29:52 Done.
+
// Synthesize an event for dragging, since we can't be sure that
// [NSApp currentEvent] will return a valid dragging event.
NSWindow* window = bridge_->ns_window();

Powered by Google App Engine
This is Rietveld 408576698