MacViews: Fix sending mouse exit event and releasing capture on D&D.

ui/views/cocoa/bridged_content_view.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_content_view.h"
 
 #include "base/logging.h"
 #import "base/mac/mac_util.h"
 #import "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 287 matching lines @@
 }
 
 - (void)clearView {
   textInputClient_ = nullptr;
   hostedView_ = nullptr;
   [[NSDistributedNotificationCenter defaultCenter] removeObserver:self];
   [cursorTrackingArea_.get() clearOwner];
   [self removeTrackingArea:cursorTrackingArea_.get()];
 }
 
+- (void)resendCapturedMouseEvent:(NSEvent*)theEvent {

[tapted, 2016/09/19 00:31:01]

I think this method has no effect in combination with your deletes in
base_view.mm, since the new methods now all just call mouseEvent. Perhaps I'm
missing something.

[snake, 2016/09/20 15:04:26]

We can use #if !defined(TOOLKIT_VIEWS) macros in base_view.mm

[tapted, 2016/09/21 10:07:05]

TOOLKIT_VIEWS is always defined on Mac, so that won't have an effect.

Anyway, let's remove part of the diff - having it makes stacks more complex and
there's no guarantee that it can protect against all hypothetical changes.

Plus with this gone, there's so little on top of the base_view.mm change that
I'm fine with landing them together.

[snake, 2016/09/21 12:29:52]

Done.

+  // We should resend messages by type, to correct processing it in
+  // base_view.mm.
+  switch ([theEvent type]) {
+    case NSLeftMouseDown:
+      [self mouseDown:theEvent];
+      break;
+    case NSLeftMouseUp:
+      [self mouseUp:theEvent];
+      break;
+    case NSRightMouseDown:
+      [self rightMouseDown:theEvent];
+      break;
+    case NSRightMouseUp:
+      [self rightMouseUp:theEvent];
+      break;
+    case NSOtherMouseDown:
+      [self otherMouseDown:theEvent];
+      break;
+    case NSOtherMouseUp:
+      [self otherMouseUp:theEvent];
+      break;
+    case NSMouseMoved:
+      [self mouseMoved:theEvent];
+      break;
+    case NSLeftMouseDragged:
+      [self mouseDragged:theEvent];
+      break;
+    case NSRightMouseDragged:
+      [self rightMouseDragged:theEvent];
+      break;
+    case NSOtherMouseDragged:
+      [self otherMouseDragged:theEvent];
+      break;
+    case NSMouseEntered:
+      [self mouseEntered:theEvent];
+      break;
+    case NSMouseExited:
+      [self mouseExited:theEvent];
+      break;
+    default:
+      [self mouseEvent:theEvent];
+  }
+}
+
 - (void)processCapturedMouseEvent:(NSEvent*)theEvent {
   if (!hostedView_)
     return;
 
   NSWindow* source = [theEvent window];
   NSWindow* target = [self window];
   DCHECK(target);
 
   // If it's the view's window, process normally.
   if ([target isEqual:source]) {
-    [self mouseEvent:theEvent];
+    [self resendCapturedMouseEvent:theEvent];
     return;
   }
 
   ui::MouseEvent event(theEvent);
   event.set_location(
       MovePointToWindow([theEvent locationInWindow], source, target));
   hostedView_->GetWidget()->OnMouseEvent(&event);
 }
 
 - (void)updateTooltipIfRequiredAt:(const gfx::Point&)locationInContent {
@@ skipping 1027 matching lines @@
   }
 
   return [super accessibilityAttributeValue:attribute];
 }
 
 - (id)accessibilityHitTest:(NSPoint)point {
   return [hostedView_->GetNativeViewAccessible() accessibilityHitTest:point];
 }
 
 @end