Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: content/browser/download/save_package.h

Issue 233723002: Workarounding fix for save complete page problems. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/save_item.cc ('k') | content/browser/download/save_package.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/save_package.h
diff --git a/content/browser/download/save_package.h b/content/browser/download/save_package.h
index 1ab429e16b960c3083104e88f65a6369b12649a1..54abe8b7a488771f363fd973911bed6a93d4f56d 100644
--- a/content/browser/download/save_package.h
+++ b/content/browser/download/save_package.h
@@ -212,6 +212,11 @@ class CONTENT_EXPORT SavePackage
const std::string& data,
int32 status);
+ // This method is a result of a flawed save page architecture,
+ // which doesn't allow to save more than one serializable resource per url.
+ // So if this is about to happen, we must record it and log it.
+ void OnWriteToFinishedFile(bool failed, const SaveItem& item);
+
typedef base::hash_map<std::string, SaveItem*> SaveUrlItemMap;
// in_progress_items_ is map of all saving job in in-progress state.
SaveUrlItemMap in_progress_items_;
« no previous file with comments | « content/browser/download/save_item.cc ('k') | content/browser/download/save_package.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698