chrome/browser/download/save_page_browsertest.cc - Issue 233723002: Workarounding fix for save complete page problems.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 233723002: Workarounding fix for save complete page problems. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/save_page_browsertest.cc

diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc

index fe1ee2810ef46d7567f35122673b7383189b2a8a..08d819ec04027a0364538b8116251fb97f464cc9 100644

--- a/chrome/browser/download/save_page_browsertest.cc

+++ b/chrome/browser/download/save_page_browsertest.cc

@@ -259,8 +259,10 @@ class SavePackageFinishedObserver : public content::DownloadManager::Observer {

}

// DownloadManager::Observer:

- virtual void OnSavePackageSuccessfullyFinished(

- content::DownloadManager* manager, content::DownloadItem* item) OVERRIDE {

+ virtual void OnSavePackageFinished(

+ bool success,

+ content::DownloadManager* manager,

+ content::DownloadItem* item) OVERRIDE {

callback_.Run();

}

virtual void ManagerGoingDown(content::DownloadManager* manager) OVERRIDE {