Workarounding fix for save complete page problems.

content/browser/download/save_package.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/save_package.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/i18n/file_util_icu.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/stl_util.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_split.h"
+#include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread.h"
 #include "content/browser/download/download_item_impl.h"
 #include "content/browser/download/download_manager_impl.h"
 #include "content/browser/download/download_stats.h"
 #include "content/browser/download/save_file.h"
 #include "content/browser/download/save_file_manager.h"
 #include "content/browser/download/save_item.h"
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
@@ skipping 1058 matching lines @@
                      file_manager_,
                      it->second->save_id(),
                      it->second->url(),
                      id,
                      true));
     }
     return;
   }
 
   SaveUrlItemMap::iterator it = in_progress_items_.find(frame_url.spec());
-  if (it == in_progress_items_.end()) {
+  SaveItem* save_item = NULL;
+  if (it != in_progress_items_.end()) {
+    save_item = it->second;
+    if (save_item->last_data_received()) {
+      OnWriteToFinishedFile(false, *save_item);
+      // No point in writing the received data in such case.
+      // Otherwise we might stop the process of writing the already existing
+      // file (of the save_item).
+      return;
+    }
+  } else {
     for (SavedItemMap::iterator saved_it = saved_success_items_.begin();
-      saved_it != saved_success_items_.end(); ++saved_it) {
+         saved_it != saved_success_items_.end(); ++saved_it) {
       if (saved_it->second->url() == frame_url) {
-        wrote_to_completed_file_ = true;
+        OnWriteToFinishedFile(false, *saved_it->second);
         break;
       }
     }
 
     it = saved_failed_items_.find(frame_url.spec());
     if (it != saved_failed_items_.end())
-      wrote_to_failed_file_ = true;
+      OnWriteToFinishedFile(true, *it->second);
 
     return;
   }
 
-  SaveItem* save_item = it->second;
   DCHECK(save_item->save_source() == SaveFileCreateInfo::SAVE_FILE_FROM_DOM);
 
   if (!data.empty()) {
     // Prepare buffer for saving HTML data.
     scoped_refptr<net::IOBuffer> new_data(new net::IOBuffer(data.size()));
     memcpy(new_data->data(), data.data(), data.size());
 
     // Call write file functionality in file thread.
     BrowserThread::PostTask(
         BrowserThread::FILE, FROM_HERE,
         base::Bind(&SaveFileManager::UpdateSaveProgress,
                    file_manager_,
                    save_item->save_id(),
                    new_data,
                    static_cast<int>(data.size())));
   }
 
   // Current frame is completed saving, call finish in file thread.
   if (flag == WebPageSerializerClient::CurrentFrameIsFinished) {
     VLOG(20) << " " << __FUNCTION__ << "()"
              << " save_id = " << save_item->save_id()
              << " url = \"" << save_item->url().spec() << "\"";
+
+    save_item->SetLastDataReceived();
+
     BrowserThread::PostTask(
         BrowserThread::FILE, FROM_HERE,
         base::Bind(&SaveFileManager::SaveFinished,
                    file_manager_,
                    save_item->save_id(),
                    save_item->url(),
                    id,
                    true));
   }
 }
 
+void SavePackage::OnWriteToFinishedFile(bool failed, const SaveItem& item) {
+  std::string warning = base::StringPrintf(
+      "Received more data for save item with save_id = %d, url = \"%s\".",
+      item.save_id(),
+      item.url().spec().c_str());
+  if (failed) {
+    wrote_to_failed_file_ = true;
+    LOG(WARNING) << warning << " The item is failed - ignoring the data.";
+  } else {
+    wrote_to_completed_file_ = true;
+    LOG(WARNING) << warning
+        << " The item is already finished - ignoring the data.";
+  }
+}
+
 // Ask for all savable resource links from backend, include main frame and
 // sub-frame.
 void SavePackage::GetAllSavableResourceLinksForCurrentPage() {
   if (wait_state_ != START_PROCESS)
     return;
 
   wait_state_ = RESOURCES_LIST;
   Send(new ViewMsg_GetAllSavableResourceLinksForCurrentPage(routing_id(),
                                                             page_url_));
 }
@@ skipping 283 matching lines @@
 }
 
 void SavePackage::OnDownloadDestroyed(DownloadItem* download) {
   StopObservation();
 }
 
 void SavePackage::FinalizeDownloadEntry() {
   DCHECK(download_);
   DCHECK(download_manager_);
 
-  download_manager_->OnSavePackageSuccessfullyFinished(download_);
+  download_manager_->OnSavePackageFinished(
+      wait_state_ == FAILED ? false : true, download_);
   StopObservation();
 }
 
 }  // namespace content