CrOS Window cycle ui - set widget bounds with initparams to avoid extra

ash/common/wm/window_cycle_list.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/wm/window_cycle_list.h"
 
 #include <list>
 #include <map>
 
 #include "ash/common/shell_window_ids.h"
@@ skipping 595 matching lines @@
   params.delegate = cycle_view_;
   params.type = views::Widget::InitParams::TYPE_WINDOW_FRAMELESS;
   params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;
   params.accept_events = true;
   params.name = "WindowCycleList (Alt+Tab)";
   // TODO(estade): make sure nothing untoward happens when the lock screen
   // or a system modal dialog is shown.
   WmWindow* root_window = WmShell::Get()->GetRootWindowForNewWindows();
   root_window->GetRootWindowController()->ConfigureWidgetInitParamsForContainer(
       widget, kShellWindowId_OverlayContainer, &params);
-  widget->Init(params);
-
-  screen_observer_.Add(display::Screen::GetScreen());
   gfx::Rect widget_rect = root_window->GetDisplayNearestWindow().bounds();
   int widget_height = cycle_view_->GetPreferredSize().height();
   widget_rect.set_y((widget_rect.height() - widget_height) / 2);
   widget_rect.set_height(widget_height);
-  widget->SetBounds(widget_rect);
+  params.bounds = widget_rect;
+  widget->Init(params);
+
+  screen_observer_.Add(display::Screen::GetScreen());

[sky, 2016/09/13 19:44:02]

optional: if you're moving this around, how about moving it to the end/beginning
of the function. It isn't inherently related to the creating the widget and
having it in the middle of creating/using the widget is a bit confusing.

   widget->Show();
   widget->SetCapture(cycle_view_);
   widget->set_auto_release_capture(false);
   cycle_ui_widget_ = widget;
 }
 
 }  // namespace ash