Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2337203002: [SVGDom] Linear gradient 'spreadMethod' support (Closed)

Created:
4 years, 3 months ago by f(malita)
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -44 lines) Patch
M experimental/svg/model/SkSVGAttribute.h View 1 chunk +1 line, -0 lines 0 comments Download
M experimental/svg/model/SkSVGAttributeParser.h View 1 chunk +1 line, -0 lines 0 comments Download
M experimental/svg/model/SkSVGAttributeParser.cpp View 1 chunk +23 lines, -0 lines 0 comments Download
M experimental/svg/model/SkSVGDOM.cpp View 2 chunks +43 lines, -30 lines 0 comments Download
M experimental/svg/model/SkSVGLinearGradient.h View 2 chunks +3 lines, -1 line 0 comments Download
M experimental/svg/model/SkSVGLinearGradient.cpp View 3 chunks +18 lines, -2 lines 0 comments Download
M experimental/svg/model/SkSVGTypes.h View 1 1 chunk +24 lines, -0 lines 0 comments Download
M experimental/svg/model/SkSVGValue.h View 2 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
f(malita)
4 years, 3 months ago (2016-09-13 17:21:21 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/2337203002/diff/1/experimental/svg/model/SkSVGTypes.h File experimental/svg/model/SkSVGTypes.h (right): https://codereview.chromium.org/2337203002/diff/1/experimental/svg/model/SkSVGTypes.h#newcode171 experimental/svg/model/SkSVGTypes.h:171: public: // These enum values must match those ...
4 years, 3 months ago (2016-09-13 18:16:53 UTC) #7
f(malita)
https://codereview.chromium.org/2337203002/diff/1/experimental/svg/model/SkSVGTypes.h File experimental/svg/model/SkSVGTypes.h (right): https://codereview.chromium.org/2337203002/diff/1/experimental/svg/model/SkSVGTypes.h#newcode171 experimental/svg/model/SkSVGTypes.h:171: public: On 2016/09/13 18:16:53, robertphillips wrote: > // These ...
4 years, 3 months ago (2016-09-13 18:26:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337203002/20001
4 years, 3 months ago (2016-09-13 18:26:14 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 19:56:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/cecd617a4297ffdcec632ca7e2ed1e6b61665e04

Powered by Google App Engine
This is Rietveld 408576698