Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2337183002: Add --help and --verbose options to update-w3c-test-expectations. (Closed)

Created:
4 years, 3 months ago by qyearsley
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, kojii
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add --help and --verbose options to update-w3c-test-expectations. This CL also adds more logging in update_w3c_test_expectations.py, and changes deps_updater.py to run this script with the --verbose flag. Purpose of this CL: 1. Make it easier to diagnose issues with w3c-test-autoroller in the future. 2. Start to make update-w3c-test-expectations better to use directly. BUG=643761 Committed: https://crrev.com/194e7e00f26329a3f0170e831c9c07b61ef20aeb Cr-Commit-Position: refs/heads/master@{#418718}

Patch Set 1 #

Patch Set 2 : Add basic test and more logging debug statements #

Patch Set 3 : Remove unrelated files, remove extra parse_args function and a couple logging statements #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -8 lines) Patch
M third_party/WebKit/Tools/Scripts/update-w3c-test-expectations View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py View 1 2 4 chunks +16 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py View 1 3 chunks +33 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
qyearsley
4 years, 3 months ago (2016-09-14 18:18:40 UTC) #6
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-14 18:47:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337183002/40001
4 years, 3 months ago (2016-09-15 00:04:03 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-15 00:11:39 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 00:14:40 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/194e7e00f26329a3f0170e831c9c07b61ef20aeb
Cr-Commit-Position: refs/heads/master@{#418718}

Powered by Google App Engine
This is Rietveld 408576698